Skip to content

[JSC] Avoid Unnecessary Vector Usage When Argument Count is Zero in Math.hypot#46480

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Gumichocopengin8:eng/JSC-Avoid-Unnecessary-Vector-Usage-When-Argument-Count-is-Zero-in-Math-hypot
Jun 10, 2025
Merged

[JSC] Avoid Unnecessary Vector Usage When Argument Count is Zero in Math.hypot#46480
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Gumichocopengin8:eng/JSC-Avoid-Unnecessary-Vector-Usage-When-Argument-Count-is-Zero-in-Math-hypot

Conversation

@Gumichocopengin8
Copy link
Copy Markdown
Member

@Gumichocopengin8 Gumichocopengin8 commented Jun 8, 2025 •
edited by webkit-early-warning-system
Loading

cca9621

[JSC] Avoid Unnecessary Vector Usage When Argument Count is Zero in `Math.hypot`
https://bugs.webkit.org/show_bug.cgi?id=294184

Reviewed by Yusuke Suzuki and Sosuke Suzuki.

Avoid unnecessary vector usage when argument count is zero in Math.hypot

* Source/JavaScriptCore/runtime/MathObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/296034@main

3ff35d6

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@Gumichocopengin8 Gumichocopengin8 self-assigned this Jun 8, 2025
@Gumichocopengin8 Gumichocopengin8 requested a review from a team as a code owner June 8, 2025 19:15
@Gumichocopengin8 Gumichocopengin8 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 8, 2025
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Jun 8, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3ff35d6)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

sosukesuzuki
sosukesuzuki approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@sosukesuzuki sosukesuzuki added the merge-queue Applied to send a pull request to merge-queue label Jun 10, 2025
@Gumichocopengin8 @sosukesuzuki
[JSC] Avoid Unnecessary Vector Usage When Argument Count is Zero in `…
cca9621 
…Math.hypot`

https://bugs.webkit.org/show_bug.cgi?id=294184

Reviewed by Yusuke Suzuki and Sosuke Suzuki.

Avoid unnecessary vector usage when argument count is zero in Math.hypot

* Source/JavaScriptCore/runtime/MathObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/296034@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Avoid-Unnecessary-Vector-Usage-When-Argument-Count-is-Zero-in-Math-hypot branch from 3ff35d6 to cca9621 Compare June 10, 2025 11:58
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Jun 10, 2025

Committed 296034@main (cca9621): https://commits.webkit.org/296034@main

Reviewed commits have been landed. Closing PR #46480 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cca9621 into WebKit:main Jun 10, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Constellation Constellation Constellation approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

@Gumichocopengin8 Gumichocopengin8

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gumichocopengin8 @webkit-early-warning-system @webkit-commit-queue @Constellation @sosukesuzuki