Skip to content

[JSC] Fold StringCharCodeAt and StringCharAt#46532

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/JSC-Fold-StringCharCodeAt-and-StringCharAt
Jun 10, 2025
Merged

[JSC] Fold StringCharCodeAt and StringCharAt#46532
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/JSC-Fold-StringCharCodeAt-and-StringCharAt

Conversation

@Constellation
Copy link
Copy Markdown
Member

@Constellation Constellation commented Jun 10, 2025

@Constellation Constellation requested a review from a team as a code owner June 10, 2025 08:33
@Constellation Constellation self-assigned this Jun 10, 2025
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 10, 2025
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

Starting EWS tests for e53fded. Live statuses available at the PR page, #46532

Copy link
Copy Markdown
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 10, 2025
https://bugs.webkit.org/show_bug.cgi?id=294242
rdar://152924008

Reviewed by Sosuke Suzuki.

Add very simple AI folding rules for StringCharCodeAt and StringCharAt:
doing folding when inputs are constant.

* JSTests/stress/string-indexed-fold.js: Added.
(shouldBe):
(test0):
(test1):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

Canonical link: https://commits.webkit.org/296036@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Fold-StringCharCodeAt-and-StringCharAt branch from e53fded to 097a025 Compare June 10, 2025 14:54
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 296036@main (097a025): https://commits.webkit.org/296036@main

Reviewed commits have been landed. Closing PR #46532 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 097a025 into WebKit:main Jun 10, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants