Skip to content

REGRESSION (293295@main): Missing UI in Logic Pro UAD plugins#46569

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
weinig:eng/REGRESSION-293295-main-Missing-UI-in-Logic-Pro-UAD-plugins
Jun 11, 2025
Merged

REGRESSION (293295@main): Missing UI in Logic Pro UAD plugins#46569
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
weinig:eng/REGRESSION-293295-main-Missing-UI-in-Logic-Pro-UAD-plugins

Conversation

@weinig
Copy link
Copy Markdown
Contributor

@weinig weinig commented Jun 10, 2025

ac7bad8

REGRESSION (293295@main): Missing UI in Logic Pro UAD plugins
https://bugs.webkit.org/show_bug.cgi?id=294219

Reviewed by Wenson Hsieh.

When parsing CSS URL values, treat a base URL of about:blank, implicitly used
for templates, the same as a null base URL. This allows late re-resolving of
the URL value at style building time, which will happen after the template is
cloned and instantiated.

* LayoutTests/fast/css/relative-url-in-style-in-template-expected.txt: Added.
* LayoutTests/fast/css/relative-url-in-style-in-template.html: Added.
* Source/WebCore/css/values/primitives/CSSURL.cpp:
(WebCore::CSS::completeURL):

Canonical link: https://commits.webkit.org/296076@main

ffdbdcc

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@weinig weinig self-assigned this Jun 10, 2025
@weinig weinig added the CSS Cascading Style Sheets implementation label Jun 10, 2025
@weinig weinig marked this pull request as ready for review June 11, 2025 00:07
@weinig weinig requested review from smfr and whsieh June 11, 2025 00:11
@weinig weinig added the merge-queue Applied to send a pull request to merge-queue label Jun 11, 2025
https://bugs.webkit.org/show_bug.cgi?id=294219

Reviewed by Wenson Hsieh.

When parsing CSS URL values, treat a base URL of about:blank, implicitly used
for templates, the same as a null base URL. This allows late re-resolving of
the URL value at style building time, which will happen after the template is
cloned and instantiated.

* LayoutTests/fast/css/relative-url-in-style-in-template-expected.txt: Added.
* LayoutTests/fast/css/relative-url-in-style-in-template.html: Added.
* Source/WebCore/css/values/primitives/CSSURL.cpp:
(WebCore::CSS::completeURL):

Canonical link: https://commits.webkit.org/296076@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-293295-main-Missing-UI-in-Logic-Pro-UAD-plugins branch from ffdbdcc to ac7bad8 Compare June 11, 2025 04:14
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 296076@main (ac7bad8): https://commits.webkit.org/296076@main

Reviewed commits have been landed. Closing PR #46569 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ac7bad8 into WebKit:main Jun 11, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants