[Materials] Upstream support for glass materials#46587
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jun 11, 2025
Merged
[Materials] Upstream support for glass materials#46587webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash d446e4f) Details |
Collaborator
|
EWS run on current version of this PR (hash ede99dc) Details |
aprotyas
approved these changes
Jun 11, 2025
rr-codes
reviewed
Jun 11, 2025
Contributor
There was a problem hiding this comment.
this is fine for upstreaming, but at some point this should be refactored to be more idiomatic (like omitting the Material.
Member
Author
There was a problem hiding this comment.
Noted. Will do when I rename the cases.
rr-codes
approved these changes
Jun 11, 2025
https://bugs.webkit.org/show_bug.cgi?id=294306 rdar://153029937 Reviewed by Abrar Rahman Protyasha and Richard Robinson. Upstream support for the use of `-apple-visual-effect` with glass materials. Renaming and refactoring to come in follow-up patches. * Source/WTF/wtf/PlatformHave.h: `HAVE_MATERIAL_EFFECT` is unused. `HAVE_MATERIAL_HOSTING` is not. Merge the two. * Source/WebCore/css/CSSPrimitiveValueMappings.h: (WebCore::toCSSValueID): (WebCore::fromCSSValueID): * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSPropertyParserConsumer+AppleVisualEffect.cpp: (WebCore::CSSPropertyParserHelpers::isKeywordValidForAppleVisualEffect): * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources-output.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Platform/cocoa/WKMaterialHostingSupport.swift: (MaterialHostingView.resolvedMaterialEffect(for:)): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/AppleVisualEffectTests.mm: (TestWebKitAPI::TEST(AppleVisualEffect, GlassMaterialParsing)): (TestWebKitAPI::TEST(AppleVisualEffect, GlassMaterialParsingWithoutUseSystemAppearance)): (TestWebKitAPI::TEST(AppleVisualEffect, MediaControlsGlassMaterialParsing)): (TestWebKitAPI::TEST(AppleVisualEffect, MediaControlsGlassMaterialParsingWithoutUseSystemAppearance)): (TestWebKitAPI::TEST(AppleVisualEffect, MediaControlsSubduedGlassMaterialParsing)): (TestWebKitAPI::TEST(AppleVisualEffect, MediaControlsSubduedGlassMaterialParsingWithoutUseSystemAppearance)): (TestWebKitAPI::TEST(AppleVisualEffect, SubduedGlassMaterialParsing)): (TestWebKitAPI::TEST(AppleVisualEffect, SubduedGlassMaterialParsingWithoutUseSystemAppearance)): (TestWebKitAPI::TEST(AppleVisualEffect, NoCrashWhenRemovingLayers)): Canonical link: https://commits.webkit.org/296094@main
ede99dc to
66fc5e1
Compare
Collaborator
|
Committed 296094@main (66fc5e1): https://commits.webkit.org/296094@main Reviewed commits have been landed. Closing PR #46587 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 webkitpy
66fc5e1
ede99dc