OverlayRegions should handle OverflowScrollProxyNodes correctly#46676
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jun 13, 2025
Merged
OverlayRegions should handle OverflowScrollProxyNodes correctly#46676webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash bc84763) Details |
bc84763 to
0cc934c
Compare
Collaborator
|
EWS run on previous version of this PR (hash 0cc934c) Details |
smfr
approved these changes
Jun 13, 2025
0cc934c to
86af715
Compare
Collaborator
|
EWS run on current version of this PR (hash 86af715) Details |
Collaborator
|
EWS run on current version of this PR (hash 86af715) Details |
https://bugs.webkit.org/show_bug.cgi?id=294408 <rdar://141299377> Reviewed by Simon Fraser. When configuring a ScrollView for OverlayRegions, associate the layers for any overflow related node (scrolling proxy). * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (configureScrollViewWithOverlayRegionsIDs): Call the new `_associateRelatedLayersForOverlayRegions`. (-[WKWebView _selectOverlayRegionScrollView:]): (-[WKWebView _resetOverlayRegions]): (-[WKWebView _updateOverlayRegions:destroyedLayers:]): Update method signatures for the new `OverlayRegionCandidatesMap`. * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h: * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm: (WebKit::RemoteScrollingCoordinatorProxyIOS::overlayRegionCandidates const): (WebKit:: const): Deleted. The `overlayRegionCandidates` method now returns a Map with the associated layers for overflow related nodes. * Source/WebKit/UIProcess/ios/WKBaseScrollView.h: * Source/WebKit/UIProcess/ios/WKBaseScrollView.mm: (-[WKBaseScrollView _associateRelatedLayersForOverlayRegions:with:]): Add a stub for the new method in Additions. * Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm: (dumpUIView): Add an associated layers count to the dump format. * LayoutTests/overlay-region/full-page-overflow-expected.txt: * LayoutTests/overlay-region/full-page-overflow-scrolling-expected.txt: * LayoutTests/overlay-region/snapping-expected.txt: Update tests expectations with associated layers. * LayoutTests/overlay-region/overflow-with-proxy-expected.txt: Added. * LayoutTests/overlay-region/overflow-with-proxy.html: Added. Add a new test. Canonical link: https://commits.webkit.org/296201@main
86af715 to
211c2ae
Compare
Collaborator
|
Committed 296201@main (211c2ae): https://commits.webkit.org/296201@main Reviewed commits have been landed. Closing PR #46676 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 style
211c2ae
86af715
🧪 mac-AS-debug-wk2