Skip to content

[WPE] WPE Platform: add initial API tests for wayland platform#46900

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
carlosgcampos:wpe-platform-api-tests-wayland
Jun 23, 2025
Merged

[WPE] WPE Platform: add initial API tests for wayland platform#46900
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
carlosgcampos:wpe-platform-api-tests-wayland

Conversation

@carlosgcampos
Copy link
Copy Markdown
Contributor

@carlosgcampos carlosgcampos commented Jun 18, 2025

4141c48

[WPE] WPE Platform: add initial API tests for wayland platform
https://bugs.webkit.org/show_bug.cgi?id=294671

Reviewed by Carlos Alberto Lopez Perez.

Add an intial test to check we can create a WPEDisplayWayland and
connect to the wayland display. The script run-wpe-tests now detects if
a WPE Platform Wayland test is going to be run and it starts a weston
driver to ensure there's a wayland display to connect.

Canonical link: https://commits.webkit.org/296508@main

b1254a4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings loading 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ❌ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@carlosgcampos carlosgcampos requested a review from a team as a code owner June 18, 2025 12:27
@carlosgcampos carlosgcampos self-assigned this Jun 18, 2025
@carlosgcampos carlosgcampos added the WPE WebKit WebKit WPE component label Jun 18, 2025
@carlosgcampos
Copy link
Copy Markdown
Contributor Author

Test is working and weston is launched, the failure is because of a warning in WPECursorTheme. I guess we could use something different than g_warning there, or make warnings non fatal in those tests, or install cursors in the bots, or include a few builtin cursors in the library to ensure we never reach that point.

Comment thread Tools/glib/api_test_runner.py Outdated
Comment thread Tools/glib/api_test_runner.py Outdated
Comment thread Tools/glib/api_test_runner.py Outdated
Comment thread Tools/glib/api_test_runner.py Outdated
@carlosgcampos carlosgcampos force-pushed the wpe-platform-api-tests-wayland branch from a7406b9 to b1254a4 Compare June 23, 2025 12:55
@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 23, 2025
https://bugs.webkit.org/show_bug.cgi?id=294671

Reviewed by Carlos Alberto Lopez Perez.

Add an intial test to check we can create a WPEDisplayWayland and
connect to the wayland display. The script run-wpe-tests now detects if
a WPE Platform Wayland test is going to be run and it starts a weston
driver to ensure there's a wayland display to connect.

Canonical link: https://commits.webkit.org/296508@main
@webkit-commit-queue webkit-commit-queue force-pushed the wpe-platform-api-tests-wayland branch from b1254a4 to 4141c48 Compare June 23, 2025 14:17
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 296508@main (4141c48): https://commits.webkit.org/296508@main

Reviewed commits have been landed. Closing PR #46900 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4141c48 into WebKit:main Jun 23, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 23, 2025
@carlosgcampos carlosgcampos deleted the wpe-platform-api-tests-wayland branch June 23, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants