[Cocoa] Remove unneeded WTFLogChannel::subsystem

[aperezdc]

7b4b061

[Cocoa] Remove unneeded WTFLogChannel::subsystem
https://bugs.webkit.org/show_bug.cgi?id=295263

Reviewed by Alex Christensen.

The Cocoa ports only use the WTFLogChannel::subsystem struct member
when calling os_log_create(), and as with the other ports, the value
is picked from the LOG_CHANNEL_WEBKIT_SUBSYSTEM macro for every
WTFLogChannel instance. Therefore, it is possible to use the macro
directly in the os_log_create() call.

As the subsystem is always picked from LOG_CHANNEL_WEBKIT_SUBSYSTEM,
this also simplifies the DEFINE_LOG_CHANNEL_[WITH_DETAILS] macros to
remove the parameter and removes the need for DEFINE_*_LOG_CHANNEL
in each component, where it is possible to use DEFINE_LOG_CHANNEL
instead.

This is a follow-up to 296858@main.

* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/Assertions.h:
* Source/WTF/wtf/Logging.cpp:
* Source/WebCore/PAL/pal/Logging.cpp:
* Source/WebCore/platform/Logging.cpp:
* Source/WebDriver/Logging.cpp:
* Source/WebGPU/WebGPU/Internal/Logging.cpp:
* Source/WebKit/Platform/Logging.cpp:
* Source/WebKitLegacy/mac/Misc/WebKitLogging.m:
* Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp:

Canonical link: https://commits.webkit.org/298529@main

93cfc3e

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	💥 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	🛠 jsc-armv7
	✅ 🛠 tv-sim		🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash d32f1b3)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 playstation
	❌ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch
	❌ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 1cf1cd0)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	❌ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

[annevk]

Someone else should probably review, but I noticed a typo in the commit message: "the value is the picked from the LOG_CHANNEL_WEBKIT_SUBSYSTEM macro" should presumably read "the value is picked from ..."

[webkit-early-warning-system]

EWS run on current version of this PR (hash 93cfc3e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	💥 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	🛠 jsc-armv7
	✅ 🛠 tv-sim		🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

[aperezdc]

Someone else should probably review, but I noticed a typo in the commit message: "the value is the picked from the LOG_CHANNEL_WEBKIT_SUBSYSTEM macro" should presumably read "the value is picked from ..."

Indeed, thanks. I have now updated the patch with the typo fixed in the commit log.

[webkit-commit-queue]

Committed 298529@main (7b4b061): https://commits.webkit.org/298529@main

Reviewed commits have been landed. Closing PR #47429 and removing active labels.