Skip to content

Use smart pointer in MediaSelectionGroupAVFObjC.mm#47882

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rwlbuis:eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm
Oct 1, 2025
Merged

Use smart pointer in MediaSelectionGroupAVFObjC.mm#47882
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rwlbuis:eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm

Conversation

@rwlbuis
Copy link
Copy Markdown
Contributor

@rwlbuis rwlbuis commented Jul 11, 2025

41d5858

Use smart pointer in MediaSelectionGroupAVFObjC.mm
https://bugs.webkit.org/show_bug.cgi?id=295770

Reviewed by Ryosuke Niwa.

Fix remaining warnings of type [alpha.webkit.UnretainedLocalVarsCheckerExpectations].

* Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionOptionAVFObjC::index const):
(WebCore::MediaSelectionOptionAVFObjC::assetTrack const):
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired):

Canonical link: https://commits.webkit.org/300821@main

bfa97dc

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rwlbuis rwlbuis self-assigned this Jul 11, 2025
@rwlbuis rwlbuis added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jul 11, 2025
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Safer C++ Build #43510 (e82da6c)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WebCore --UnretainedCallArgsChecker platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm --UnretainedLocalVarsChecker platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm

@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from e82da6c to fab20ce Compare July 11, 2025 14:25
@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from fab20ce to 41202cc Compare July 14, 2025 09:15
@rwlbuis rwlbuis added the skip-ews Applied to prevent a change from being run on EWS label Jul 14, 2025
@rwlbuis rwlbuis removed the skip-ews Applied to prevent a change from being run on EWS label Jul 14, 2025
@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from 41202cc to 7509606 Compare July 14, 2025 11:26
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 14, 2025
@rwlbuis rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Jul 14, 2025
@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from 7509606 to f08c2a9 Compare July 14, 2025 13:02
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Safer C++ Build #43848 (f08c2a9)

❌ Found 1 failing file with 3 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from f08c2a9 to 40c59c3 Compare July 16, 2025 10:27
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 16, 2025
@rwlbuis rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Jul 17, 2025
@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from 40c59c3 to b57bde1 Compare July 17, 2025 09:30
@rwlbuis rwlbuis marked this pull request as ready for review July 17, 2025 13:13
@rwlbuis rwlbuis requested a review from jyavenard July 17, 2025 13:14
@rwlbuis
Copy link
Copy Markdown
Contributor Author

rwlbuis commented Jul 17, 2025

@jyavenard I think the PAL::getAVMediaSelectionGroupClass() related warnings may be better fixed by the clang-tidy checker, but the rest should still be valuable.

@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from b57bde1 to 26ea0ea Compare September 3, 2025 14:57
@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from 26ea0ea to bd4d035 Compare September 30, 2025 14:08
@rwlbuis rwlbuis added the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2025
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Commit message contains (OOPS!), blocking PR #47882. Details: Build #26037

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Sep 30, 2025
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Safer C++ Build #56335 (bd4d035)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WebCore --UnretainedCallArgsChecker platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm

@rwlbuis rwlbuis removed the merging-blocked Applied to prevent a change from being merged label Oct 1, 2025
@rwlbuis rwlbuis force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from bd4d035 to bfa97dc Compare October 1, 2025 08:44
@rwlbuis rwlbuis added the merge-queue Applied to send a pull request to merge-queue label Oct 1, 2025
https://bugs.webkit.org/show_bug.cgi?id=295770

Reviewed by Ryosuke Niwa.

Fix remaining warnings of type [alpha.webkit.UnretainedLocalVarsCheckerExpectations].

* Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionOptionAVFObjC::index const):
(WebCore::MediaSelectionOptionAVFObjC::assetTrack const):
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired):

Canonical link: https://commits.webkit.org/300821@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch from bfa97dc to 41d5858 Compare October 1, 2025 11:51
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 300821@main (41d5858): https://commits.webkit.org/300821@main

Reviewed commits have been landed. Closing PR #47882 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 41d5858 into WebKit:main Oct 1, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 1, 2025
@rwlbuis rwlbuis deleted the eng/Use-smart-pointer-in-MediaSelectionGroupAVFObjC-mm branch October 9, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants