Use smart pointer in MediaSelectionGroupAVFObjC.mm#47882
Conversation
|
EWS run on previous version of this PR (hash e82da6c) Details |
Safer C++ Build #43510 (e82da6c)
|
e82da6c to
fab20ce
Compare
|
EWS run on previous version of this PR (hash fab20ce) Details |
fab20ce to
41202cc
Compare
|
EWS run on previous version of this PR (hash 41202cc) Details
|
41202cc to
7509606
Compare
|
EWS run on previous version of this PR (hash 7509606) Details |
7509606 to
f08c2a9
Compare
|
EWS run on previous version of this PR (hash f08c2a9) Details |
Safer C++ Build #43848 (f08c2a9)❌ Found 1 failing file with 3 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
f08c2a9 to
40c59c3
Compare
|
EWS run on previous version of this PR (hash 40c59c3) Details |
40c59c3 to
b57bde1
Compare
|
EWS run on previous version of this PR (hash b57bde1) Details |
|
@jyavenard I think the PAL::getAVMediaSelectionGroupClass() related warnings may be better fixed by the clang-tidy checker, but the rest should still be valuable. |
b57bde1 to
26ea0ea
Compare
|
EWS run on previous version of this PR (hash 26ea0ea) Details |
26ea0ea to
bd4d035
Compare
|
EWS run on previous version of this PR (hash bd4d035) Details |
|
Commit message contains (OOPS!), blocking PR #47882. Details: Build #26037 |
Safer C++ Build #56335 (bd4d035)
|
bd4d035 to
bfa97dc
Compare
|
EWS run on current version of this PR (hash bfa97dc) Details |
https://bugs.webkit.org/show_bug.cgi?id=295770 Reviewed by Ryosuke Niwa. Fix remaining warnings of type [alpha.webkit.UnretainedLocalVarsCheckerExpectations]. * Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations: * Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations: * Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm: (WebCore::MediaSelectionOptionAVFObjC::index const): (WebCore::MediaSelectionOptionAVFObjC::assetTrack const): (WebCore::MediaSelectionGroupAVFObjC::updateOptions): (WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired): Canonical link: https://commits.webkit.org/300821@main
bfa97dc to
41d5858
Compare
|
Committed 300821@main (41d5858): https://commits.webkit.org/300821@main Reviewed commits have been landed. Closing PR #47882 and removing active labels. |
41d5858
bfa97dc
🧪 win-tests