Skip to content

PointerLockRequestResult should be defined in PointerLockController.h#48559

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
aprotyas:eng/296519
Jul 28, 2025
Merged

PointerLockRequestResult should be defined in PointerLockController.h#48559
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
aprotyas:eng/296519

Conversation

@aprotyas
Copy link
Copy Markdown
Member

@aprotyas aprotyas commented Jul 26, 2025

a5ad663

PointerLockRequestResult should be defined in PointerLockController.h
https://bugs.webkit.org/show_bug.cgi?id=296519
rdar://156781898

Reviewed by Aditya Keerthi.

It makes sense for this enum declaration to live next to
PointerLockController, and not in ChromeClient, which is mainly just
glue to get to the UI process.

* Source/WebCore/page/ChromeClient.cpp:
(WebCore::ChromeClient::requestPointerLock):
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::requestPointerLock): Deleted.
* Source/WebCore/page/PointerLockController.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::requestPointerLock):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:

Canonical link: https://commits.webkit.org/297951@main

7a67f9f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aprotyas aprotyas requested a review from cdumez as a code owner July 26, 2025 10:28
@aprotyas aprotyas self-assigned this Jul 26, 2025
@aprotyas aprotyas added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jul 26, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 26, 2025
@aprotyas aprotyas removed the merging-blocked Applied to prevent a change from being merged label Jul 26, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 26, 2025
@aprotyas aprotyas removed the merging-blocked Applied to prevent a change from being merged label Jul 26, 2025
@aprotyas
Copy link
Copy Markdown
Member Author

Thank you for the review!

@aprotyas aprotyas added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 28, 2025
https://bugs.webkit.org/show_bug.cgi?id=296519
rdar://156781898

Reviewed by Aditya Keerthi.

It makes sense for this enum declaration to live next to
PointerLockController, and not in ChromeClient, which is mainly just
glue to get to the UI process.

* Source/WebCore/page/ChromeClient.cpp:
(WebCore::ChromeClient::requestPointerLock):
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::requestPointerLock): Deleted.
* Source/WebCore/page/PointerLockController.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::requestPointerLock):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:

Canonical link: https://commits.webkit.org/297951@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 297951@main (a5ad663): https://commits.webkit.org/297951@main

Reviewed commits have been landed. Closing PR #48559 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a5ad663 into WebKit:main Jul 28, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 28, 2025
@aprotyas aprotyas deleted the eng/296519 branch July 28, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants