[Safer CPP] Address issues in ExternalTexture#49032
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 7, 2025
Merged
[Safer CPP] Address issues in ExternalTexture#49032webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 24581f5) Details
|
24581f5 to
1c674bf
Compare
Collaborator
|
EWS run on current version of this PR (hash 1c674bf) Details
|
Contributor
Author
|
EWS all green. Ready for review! |
mwyrzykowski
approved these changes
Aug 7, 2025
https://bugs.webkit.org/show_bug.cgi?id=297022 rdar://157701524 Reviewed by Mike Wyrzykowski. Address SaferCPP issues in ExternalTexture. * Source/WebGPU/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations: * Source/WebGPU/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations: * Source/WebGPU/WebGPU/ExternalTexture.mm: (WebGPU::Device::createExternalTexture): (WebGPU::ExternalTexture::update): Canonical link: https://commits.webkit.org/298362@main
1c674bf to
c810a16
Compare
Collaborator
|
Committed 298362@main (c810a16): https://commits.webkit.org/298362@main Reviewed commits have been landed. Closing PR #49032 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 mac-wk1
c810a16
1c674bf
🧪 win-tests🛠 playstation