Skip to content

[Safer CPP] Address issues in ExternalTexture#49032

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ruthvikkonda:safercpp-external-texture
Aug 7, 2025
Merged

[Safer CPP] Address issues in ExternalTexture#49032
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ruthvikkonda:safercpp-external-texture

Conversation

@ruthvikkonda
Copy link
Contributor

@ruthvikkonda ruthvikkonda commented Aug 6, 2025

c810a16

[Safer CPP] Address issues in ExternalTexture
https://bugs.webkit.org/show_bug.cgi?id=297022
rdar://157701524

Reviewed by Mike Wyrzykowski.

Address SaferCPP issues in ExternalTexture.

* Source/WebGPU/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebGPU/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebGPU/WebGPU/ExternalTexture.mm:
(WebGPU::Device::createExternalTexture):
(WebGPU::ExternalTexture::update):

Canonical link: https://commits.webkit.org/298362@main

1c674bf

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@ruthvikkonda ruthvikkonda self-assigned this Aug 6, 2025
@ruthvikkonda ruthvikkonda added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Aug 6, 2025
@ruthvikkonda ruthvikkonda force-pushed the safercpp-external-texture branch from 24581f5 to 1c674bf Compare August 6, 2025 23:50
@ruthvikkonda ruthvikkonda marked this pull request as ready for review August 7, 2025 02:44
@ruthvikkonda
Copy link
Contributor Author

EWS all green. Ready for review!

@roberto-apple roberto-apple added the merge-queue Applied to send a pull request to merge-queue label Aug 7, 2025
https://bugs.webkit.org/show_bug.cgi?id=297022
rdar://157701524

Reviewed by Mike Wyrzykowski.

Address SaferCPP issues in ExternalTexture.

* Source/WebGPU/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebGPU/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebGPU/WebGPU/ExternalTexture.mm:
(WebGPU::Device::createExternalTexture):
(WebGPU::ExternalTexture::update):

Canonical link: https://commits.webkit.org/298362@main
@webkit-commit-queue webkit-commit-queue force-pushed the safercpp-external-texture branch from 1c674bf to c810a16 Compare August 7, 2025 21:20
@webkit-commit-queue
Copy link
Collaborator

Committed 298362@main (c810a16): https://commits.webkit.org/298362@main

Reviewed commits have been landed. Closing PR #49032 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c810a16 into WebKit:main Aug 7, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants