Skip to content

[JSC] Do not convert to DirectConstruct / DirectCall when it is bound function or it is a non constructible constructor#49102

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Constellation:eng/JSC-Do-not-convert-to-DirectConstruct-DirectCall-when-it-is-bound-function-or-it-is-a-non-constructible-constructor
Aug 8, 2025
Merged

[JSC] Do not convert to DirectConstruct / DirectCall when it is bound function or it is a non constructible constructor#49102
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Constellation:eng/JSC-Do-not-convert-to-DirectConstruct-DirectCall-when-it-is-bound-function-or-it-is-a-non-constructible-constructor

Conversation

@Constellation
Copy link
Member

@Constellation Constellation commented Aug 8, 2025

@Constellation Constellation requested a review from a team as a code owner August 8, 2025 04:22
@Constellation Constellation self-assigned this Aug 8, 2025
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Aug 8, 2025
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 8, 2025
… function or it is a non constructible constructor

https://bugs.webkit.org/show_bug.cgi?id=297101
rdar://157813555

Reviewed by Mark Lam.

We should avoid converting this Call to DirectCall / DirectConstruct
when they are not done in strength reduction phase.

* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):

Canonical link: https://commits.webkit.org/298376@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Do-not-convert-to-DirectConstruct-DirectCall-when-it-is-bound-function-or-it-is-a-non-constructible-constructor branch from 7016ad3 to 4cc881d Compare August 8, 2025 07:21
@webkit-commit-queue
Copy link
Collaborator

Committed 298376@main (4cc881d): https://commits.webkit.org/298376@main

Reviewed commits have been landed. Closing PR #49102 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4cc881d into WebKit:main Aug 8, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants