[JSC] Do not convert to DirectConstruct / DirectCall when it is bound function or it is a non constructible constructor#49102
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 7016ad3) Details |
… function or it is a non constructible constructor https://bugs.webkit.org/show_bug.cgi?id=297101 rdar://157813555 Reviewed by Mark Lam. We should avoid converting this Call to DirectCall / DirectConstruct when they are not done in strength reduction phase. * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleInlining): Canonical link: https://commits.webkit.org/298376@main
7016ad3 to
4cc881d
Compare
Collaborator
|
Committed 298376@main (4cc881d): https://commits.webkit.org/298376@main Reviewed commits have been landed. Closing PR #49102 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4cc881d
7016ad3
🧪 win-tests🛠 playstation🛠 jsc-armv7🧪 jsc-armv7-tests