Skip to content

[Safer CPP] Address issues in RenderBundleEncoder and ComputePassEncoder#49233

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ruthvikkonda:safercpp-renderbundleencoder-instance
Aug 12, 2025
Merged

[Safer CPP] Address issues in RenderBundleEncoder and ComputePassEncoder#49233
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ruthvikkonda:safercpp-renderbundleencoder-instance

Conversation

@ruthvikkonda
Copy link
Copy Markdown
Contributor

@ruthvikkonda ruthvikkonda commented Aug 11, 2025

3ee3965

[Safer CPP] Address issues in RenderBundleEncoder and ComputePassEncoder
https://bugs.webkit.org/show_bug.cgi?id=297237
rdar://158068940

Reviewed by Mike Wyrzykowski.

Address SaferCPP issues in RenderBundleEncoder and ComputePassEncoder.

* Source/WebGPU/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebGPU/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::runPredispatchIndirectCallValidation):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):

Canonical link: https://commits.webkit.org/298575@main

174f173

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@ruthvikkonda ruthvikkonda self-assigned this Aug 11, 2025
@ruthvikkonda ruthvikkonda added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Aug 11, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 11, 2025
@ruthvikkonda ruthvikkonda removed the merging-blocked Applied to prevent a change from being merged label Aug 12, 2025
@ruthvikkonda ruthvikkonda changed the title [Safer CPP] Address issues in RenderBundleEncoder and Instance [Safer CPP] Address issues in RenderBundleEncoder and ComputePassEncoder Aug 12, 2025
@ruthvikkonda ruthvikkonda force-pushed the safercpp-renderbundleencoder-instance branch from 691bb4e to 174f173 Compare August 12, 2025 01:47
@ruthvikkonda ruthvikkonda marked this pull request as ready for review August 12, 2025 16:37
@sammygill sammygill added the merge-queue Applied to send a pull request to merge-queue label Aug 12, 2025
https://bugs.webkit.org/show_bug.cgi?id=297237
rdar://158068940

Reviewed by Mike Wyrzykowski.

Address SaferCPP issues in RenderBundleEncoder and ComputePassEncoder.

* Source/WebGPU/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebGPU/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::runPredispatchIndirectCallValidation):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):

Canonical link: https://commits.webkit.org/298575@main
@webkit-commit-queue webkit-commit-queue force-pushed the safercpp-renderbundleencoder-instance branch from 174f173 to 3ee3965 Compare August 12, 2025 18:02
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 298575@main (3ee3965): https://commits.webkit.org/298575@main

Reviewed commits have been landed. Closing PR #49233 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3ee3965 into WebKit:main Aug 12, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants