Event Timing: implement interactionId logic

LayoutTests/TestExpectations

@@ -1377,32 +1377,29 @@ imported/w3c/web-platform-tests/resource-timing/fetch-cross-origin-redirect.http
 
 # Flaky timing tests:
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/click-timing.html [ Pass Failure ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/crossiframe.html [ Pass Failure ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-click.html [ Pass Failure ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/timingconditions.html [ Pass Failure ]
 
-# Requires interactionId:
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/crossiframe.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-click.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-key.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-tap.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-aux-pointerdown.html [ Skip ]
+# Timing out (missing auxclick automation?):
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-aux-pointerdown-and-pointerdown.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-auxclick.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-click.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-checkbox-space.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-link-enter.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-button-space.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keypress.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-orphan-pointerup.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-press-key-as-input.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-press-key-no-effect.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-tap.html [ Skip ]
-webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/retrieve-firstInput.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-aux-pointerdown.html [ Skip ]
+
+# Fail on local machine, pass on EWS. Probably flaky timing:
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-checkbox-space.html [ Pass Failure ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-link-enter.html [ Pass Failure ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-button-space.html [ Pass Failure ]
 
 # No browser passes, test is likely outdated:
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/modal-dialog-interrupt-paint.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/TapToStopFling.html [ Skip ]
 
-# Problems with event automation:
+# Missing tap automation, times out:
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-tap.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interaction-count-tap.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-tap.html [ Skip ]
+
+# Missing automation:
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/event-click-visibilitychange.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/selection-autoscroll.html [ Skip ]
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/crossiframe-expected.txt

@@ -1,4 +1,4 @@
 Generate a 'click' event
 
-FAIL Event Timing: entries should only be observable by its own frame. assert_equals: There should be a single first-input entry expected 1 but got 0
+PASS Event Timing: entries should only be observable by its own frame.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/disconnect-target-expected.txt

@@ -1,4 +1,3 @@
-ClickMe
 
-FAIL Event Timing: when target is disconnected, entry.target returns null. assert_equals: There should be a single first-input entry expected 1 but got 0
+PASS Event Timing: when target is disconnected, entry.target returns null.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/event-click-visibilitychange-expected.txt

@@ -1,4 +1,6 @@
 Click me
 
-FAIL Event handlers which change visibility should not measure next paint. assert_implements: Event Timing is not supported. undefined
+Harness Error (TIMEOUT), message = null
+
+TIMEOUT Event handlers which change visibility should not measure next paint. Test timed out
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/event-retarget-expected.txt

@@ -1,3 +1,3 @@
 
-FAIL Event Timing: target reports the last Event Target, i.e. nothing from shadow DOM. assert_equals: There should be a single first-input entry expected 1 but got 0
+PASS Event Timing: target reports the last Event Target, i.e. nothing from shadow DOM.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/first-input-interactionid-click-expected.txt

@@ -1,4 +1,4 @@
 Click me
 
-FAIL The interactionId of the first input entry should match the same pointerdown entry of event timing when click. assert_implements: Event Timing is not supported. undefined
+PASS The interactionId of the first input entry should match the same pointerdown entry of event timing when click.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/first-input-interactionid-key-expected.txt

@@ -1,4 +1,4 @@
 
 
-FAIL The interactionId of the first input entry should match the same keydown entry of event timing when press a key. assert_implements: Event Timing is not supported. undefined
+PASS The interactionId of the first input entry should match the same keydown entry of event timing when press a key.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/first-input-shadow-dom-expected.txt

@@ -1,3 +1,3 @@
 
-FAIL Event Timing: test first input on shadow DOM. assert_equals: expected Element node <custom-button id="custom_button"></custom-button> but got Element node <button id="inner_button_id">Click me</button>
+PASS Event Timing: test first input on shadow DOM.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interaction-count-click-expected.txt

@@ -1,5 +1,5 @@
 Click me
 Click me
 
-FAIL EventTiming: verify interactionCount for click interaction step_wait_func: interactionCount did not increase enough Timed out waiting on condition
+PASS EventTiming: verify interactionCount for click interaction
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interaction-count-press-key-expected.txt

@@ -1,4 +1,4 @@
 
 
-FAIL EventTiming: verify interactionCount for key interaction step_wait_func: interactionCount did not increase enough Timed out waiting on condition
+PASS EventTiming: verify interactionCount for key interaction
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-auxclick-expected.txt

@@ -1,4 +1,4 @@
 Right click me to bring up OS level contextmenu popup.
 
-FAIL Event Timing: verify pointerdown & pointerup reporting for mouse aux click triggered contextmenu. assert_implements: Event Timing is not supported. undefined
+PASS Event Timing: verify pointerdown & pointerup reporting for mouse aux click triggered contextmenu.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-click-expected.txt

@@ -1,4 +1,4 @@
 Click me.
 
-FAIL Event Timing: compare event timing interactionId. assert_implements: Event Timing is not supported. undefined
+PASS Event Timing: compare event timing interactionId.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-button-space-expected.txt

@@ -1,6 +1,4 @@
 Click me.
 
-Harness Error (TIMEOUT), message = null
-
-TIMEOUT Click event triggered by space key in checkbox should have the same      interaction id as that of the associated keyboard events. Test timed out
+FAIL Click event triggered by space key in checkbox should have the same      interaction id as that of the associated keyboard events. assert_equals: Click event should have the same interaction id as the keydown event. expected 1002 but got 0
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-checkbox-space-expected.txt

@@ -1,6 +1,4 @@
 
 
-Harness Error (TIMEOUT), message = null
-
-TIMEOUT Click event triggered by space key in checkbox should have the same      interaction id as that of the associated keyboard events. Test timed out
+FAIL Click event triggered by space key in checkbox should have the same      interaction id as that of the associated keyboard events. assert_equals: Click event should have the same interaction id as the keydown event. expected 1002 but got 0
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-keyboard-event-simulated-click-link-enter-expected.txt

@@ -1,5 +1,3 @@
 
-Harness Error (TIMEOUT), message = null
-
-TIMEOUT Click event triggered by space key in checkbox should have the same      interaction id as that of the associated keyboard events. Test timed out
+FAIL Click event triggered by space key in checkbox should have the same      interaction id as that of the associated keyboard events. assert_equals: Click event should have the same interaction id as the keydown event. expected 1002 but got 0
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-keypress-expected.txt

@@ -1,4 +1,4 @@
 
 
-FAIL Event Timing: compare event timing interactionId for keypress. assert_implements: Event Timing is not supported. undefined
+FAIL Event Timing: compare event timing interactionId for keypress. assert_greater_than: Should have a non-trivial interactionId expected a number greater than 0 but got 0
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-orphan-pointerup-expected.txt

@@ -1,4 +1,4 @@
 Orphan Pointerup
 
-FAIL Event Timing: Orphan pointerup should not be measured as an interaction. assert_implements: Event Timing is not supported. undefined
+PASS Event Timing: Orphan pointerup should not be measured as an interaction.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-press-key-as-input-expected.txt

@@ -1,4 +1,4 @@
 
 
-FAIL Event Timing: compare event timing interactionId for key press as input. assert_implements: Event Timing is not supported. undefined
+PASS Event Timing: compare event timing interactionId for key press as input.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-press-key-no-effect-expected.txt

@@ -1,5 +1,5 @@
 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec tempus lacinia nisi, eget tempor orci. Nullam congue pharetra arcu, et consectetur massa mollis tincidunt. Quisque odio sapien, viverra finibus lectus ac, consectetur ornare quam. In hac habitasse platea dictumst. Morbi cursus est odio, non fermentum ligula posuere vitae. Sed ullamcorper convallis rhoncus. In condimentum neque nec metus hendrerit, et cursus ipsum aliquet.
 
 
-FAIL Event Timing: compare event timing interactionId for key press with no effect. assert_implements: Event Timing is not supported. undefined
+PASS Event Timing: compare event timing interactionId for key press with no effect.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/only-observe-firstInput-expected.txt

@@ -1,4 +1,4 @@
 Generate a 'click' event
 
-FAIL Event Timing: check first-input for a PerformanceObserver observing only first-input. assert_equals: expected 1 but got 0
+PASS Event Timing: check first-input for a PerformanceObserver observing only first-input.
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/programmatic-click-not-observed-expected.txt

@@ -1,5 +1,5 @@
 Click me
 No, click me!
 
-FAIL Event Timing: events from programmatic click are not observed assert_equals: There should be a single first-input entry expected 1 but got 0
+PASS Event Timing: events from programmatic click are not observed
 

LayoutTests/imported/w3c/web-platform-tests/event-timing/retrieve-firstInput-expected.txt

@@ -1,4 +1,4 @@
 Generate a 'click' event
 
-FAIL Event Timing: check first-input after onload, observer, click, click. assert_implements: Event Timing is not supported. undefined
+PASS Event Timing: check first-input after onload, observer, click, click.
 

LayoutTests/platform/gtk/TestExpectations

@@ -99,7 +99,11 @@ webkit.org/b/290522 imported/w3c/web-platform-tests/html/canvas/offscreen/manual
 webkit.org/b/285993 imported/w3c/web-platform-tests/html/canvas/offscreen/manual/text/canvas.2d.offscreen.worker.lang.html [ ImageOnlyFailure Crash ]
 webkit.org/b/285993 imported/w3c/web-platform-tests/html/canvas/offscreen/manual/text/canvas.2d.offscreen.worker.lang.inherit.html [ ImageOnlyFailure Crash ]
 
+# Times out, possibly missing automation:
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-auxclick.html [ Skip ]
+
 # Crash mentioning WTR::UIScriptController::notImplemented() with the EventTimingEnabled feature flag
+webkit.org/b/296246 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-key.html [ Crash ]
 webkit.org/b/296246 imported/w3c/web-platform-tests/event-timing/interaction-count-tap.html [ Crash ]
 webkit.org/b/296246 imported/w3c/web-platform-tests/event-timing/TapToStopFling.html [ Crash ]
 

LayoutTests/platform/ios/TestExpectations

@@ -4497,11 +4497,22 @@ webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/buffered-flag.h
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/click-timing.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/click.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/contextmenu.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/crossiframe.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/dblclick.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/disconnect-target.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/duration-with-target-low.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/event-retarget.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-click.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-key.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/first-input-shadow-dom.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interaction-count-click.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interaction-count-press-key.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-auxclick.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-click.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-keypress.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-orphan-pointerup.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-press-key-as-input.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-press-key-no-effect.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/keydown.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/keyup.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/large-duration-threshold.html [ Skip ]
@@ -4521,6 +4532,7 @@ webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/pointerover.htm
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/pointerup.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/programmatic-click-not-observed.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/retrievability.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/retrieve-firstInput.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/shadow-dom-null-target.html [ Skip ]
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/toJSON.html [ Skip ]
 

LayoutTests/platform/mac-wk1/TestExpectations

@@ -867,6 +867,7 @@ imported/w3c/web-platform-tests/webtransport/ [ Skip ]
 
 # Event timing: times out, missing automation
 webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/contextmenu.html [ Skip ]
+webkit.org/b/214677 imported/w3c/web-platform-tests/event-timing/interactionid-orphan-pointerup.html [ Skip ]
 
 # WebKitLegacy doesn't support https-based WPT
 webkit.org/b/246719 imported/w3c/web-platform-tests/reporting/generateTestReport-honors-endpoint.https.sub.html [ Failure ]

LayoutTests/platform/win/TestExpectations

@@ -1977,6 +1977,14 @@ imported/w3c/web-platform-tests/event-timing/interaction-count-tap.html [ Crash
 imported/w3c/web-platform-tests/event-timing/interaction-count-click.html [ Skip ]
 imported/w3c/web-platform-tests/event-timing/interaction-count-press-key.html [ Skip ]
 
+# Timeout:
+imported/w3c/web-platform-tests/event-timing/interactionid-orphan-pointerup.html [ Skip ]
+
+# Fail with AccessDeniedAccess
+imported/w3c/web-platform-tests/event-timing/contextmenu.html [ Skip ]
+imported/w3c/web-platform-tests/event-timing/interactionid-auxclick.html [ Skip ]
+imported/w3c/web-platform-tests/event-timing/first-input-interactionid-key.html [ Skip ]
+
 compositing/video [ Skip ]
 editing/pasteboard [ Skip ]
 fast/attachment [ Skip ]

LayoutTests/platform/wpe/TestExpectations

@@ -567,9 +567,10 @@ webkit.org/b/244186 imported/w3c/web-platform-tests/dom/events/non-cancelable-wh
 
 webkit.org/b/286930 media/modern-media-controls/scrubber-support/scrubber-support-seek-back.html [ Crash ]
 
-# Crash mentioning WTR::UIScriptController::notImplemented() with the EventTimingEnabled feature flag
-webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/TapToStopFling.html [ Crash ]
+# Crashes with WTR::UIScriptController::notImplemented():
+webkit.org/b/296246 imported/w3c/web-platform-tests/event-timing/first-input-interactionid-key.html [ Crash ]
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/interaction-count-tap.html [ Crash ]
+webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/TapToStopFling.html [ Crash ]
 
 # Event timing: times out, probably missing automation
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/click-timing.html [ Skip ]
@@ -579,11 +580,16 @@ webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/disconnect-targ
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/duration-with-target-low.html [ Skip ]
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/event-retarget.html [ Skip ]
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/first-input-shadow-dom.html [ Skip ]
+webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/interactionid-auxclick.html [ Skip ]
+webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/interactionid-orphan-pointerup.html [ Skip ]
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/keydown.html [ Skip ]
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/large-duration-threshold.html [ Skip ]
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/medium-duration-threshold.html [ Skip ]
 webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/retrievability.html [ Skip ]
 
+webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/interactionid-click.html [ Pass ]
+webkit.org/b/244186 imported/w3c/web-platform-tests/event-timing/retrieve-firstInput.html [ Pass ]
+
 # notImplemented in WTR::UIScriptController::isShowingDateTimePicker
 fast/forms/datalist [ Skip ]
 fast/forms/date/date-show-hide-picker.html [ Skip ]

Source/WebCore/Headers.cmake

@@ -2009,6 +2009,7 @@ set(WebCore_PRIVATE_FRAMEWORK_HEADERS
     page/ElementTargetingTypes.h
     page/EmptyAttachmentElementClient.h
     page/EventHandler.h
+    page/EventTimingInteractionID.h
     page/FocusController.h
     page/FocusDirection.h
     page/FocusEventData.h
@@ -2061,8 +2062,7 @@ set(WebCore_PRIVATE_FRAMEWORK_HEADERS
     page/PageOverlayController.h
     page/PagePasteboardContext.h
     page/PartitionedSecurityOrigin.h
-    page/PerformanceEntry.h
-    page/PerformanceEventTiming.h
+    page/PerformanceEventTimingCandidate.h
     page/PerformanceLogging.h
     page/PerformanceLoggingClient.h
     page/PointerCaptureController.h