Adopt smart pointers in AccessibilityTableColumn/Row, AccessibilitySVGObject, AXCoreObject#49524
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 18, 2025
jelee53:eng/Adopt-smart-pointers-in-AccessibilityTableColumn-Row-AccessibilitySVGObject-AXCoreObject
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 406c9aa) Details |
Collaborator
Safer C++ Build #49204 (406c9aa)❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
406c9aa to
d851c14
Compare
Collaborator
|
EWS run on previous version of this PR (hash d851c14) Details
|
d851c14 to
9b91ff5
Compare
Collaborator
|
EWS run on current version of this PR (hash 9b91ff5) Details |
rniwa
approved these changes
Aug 18, 2025
58d5c97 to
e956b40
Compare
…GObject, AXCoreObject https://bugs.webkit.org/show_bug.cgi?id=297528 rdar://158574263 Reviewed by Ryosuke Niwa. Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines. * Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations: * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebCore/accessibility/AXCoreObject.cpp: (WebCore::LineDecorationStyle::LineDecorationStyle): * Source/WebCore/accessibility/AccessibilitySVGObject.cpp: (WebCore::AccessibilitySVGObject::targetForUseElement const): (WebCore::AccessibilitySVGObject::computeIsIgnored const): * Source/WebCore/accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::setColumnIndex): (WebCore::AccessibilityTableColumn::computeIsIgnored const): * Source/WebCore/accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::setRowIndex): Canonical link: https://commits.webkit.org/298860@main
e956b40 to
95e3cd6
Compare
Collaborator
|
Committed 298860@main (95e3cd6): https://commits.webkit.org/298860@main Reviewed commits have been landed. Closing PR #49524 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
95e3cd6
9b91ff5