Skip to content

Adopt smart pointers in AccessibilityTableColumn/Row, AccessibilitySVGObject, AXCoreObject#49524

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
jelee53:eng/Adopt-smart-pointers-in-AccessibilityTableColumn-Row-AccessibilitySVGObject-AXCoreObject
Aug 18, 2025
Merged

Adopt smart pointers in AccessibilityTableColumn/Row, AccessibilitySVGObject, AXCoreObject#49524
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
jelee53:eng/Adopt-smart-pointers-in-AccessibilityTableColumn-Row-AccessibilitySVGObject-AXCoreObject

Conversation

@jelee53
Copy link
Copy Markdown
Contributor

@jelee53 jelee53 commented Aug 18, 2025

95e3cd6

Adopt smart pointers in AccessibilityTableColumn/Row, AccessibilitySVGObject, AXCoreObject
https://bugs.webkit.org/show_bug.cgi?id=297528
rdar://158574263

Reviewed by Ryosuke Niwa.

Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines.

* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::LineDecorationStyle::LineDecorationStyle):
* Source/WebCore/accessibility/AccessibilitySVGObject.cpp:
(WebCore::AccessibilitySVGObject::targetForUseElement const):
(WebCore::AccessibilitySVGObject::computeIsIgnored const):
* Source/WebCore/accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::setColumnIndex):
(WebCore::AccessibilityTableColumn::computeIsIgnored const):
* Source/WebCore/accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::setRowIndex):

Canonical link: https://commits.webkit.org/298860@main

9b91ff5

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@jelee53 jelee53 self-assigned this Aug 18, 2025
@jelee53 jelee53 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Aug 18, 2025
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Safer C++ Build #49204 (406c9aa)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

@jelee53 jelee53 force-pushed the eng/Adopt-smart-pointers-in-AccessibilityTableColumn-Row-AccessibilitySVGObject-AXCoreObject branch from 406c9aa to d851c14 Compare August 18, 2025 17:50
@jelee53 jelee53 force-pushed the eng/Adopt-smart-pointers-in-AccessibilityTableColumn-Row-AccessibilitySVGObject-AXCoreObject branch from d851c14 to 9b91ff5 Compare August 18, 2025 17:52
@jelee53 jelee53 marked this pull request as ready for review August 18, 2025 22:07
@jelee53 jelee53 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 18, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-smart-pointers-in-AccessibilityTableColumn-Row-AccessibilitySVGObject-AXCoreObject branch 2 times, most recently from 58d5c97 to e956b40 Compare August 18, 2025 22:10
…GObject, AXCoreObject

https://bugs.webkit.org/show_bug.cgi?id=297528
rdar://158574263

Reviewed by Ryosuke Niwa.

Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines.

* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::LineDecorationStyle::LineDecorationStyle):
* Source/WebCore/accessibility/AccessibilitySVGObject.cpp:
(WebCore::AccessibilitySVGObject::targetForUseElement const):
(WebCore::AccessibilitySVGObject::computeIsIgnored const):
* Source/WebCore/accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::setColumnIndex):
(WebCore::AccessibilityTableColumn::computeIsIgnored const):
* Source/WebCore/accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::setRowIndex):

Canonical link: https://commits.webkit.org/298860@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-smart-pointers-in-AccessibilityTableColumn-Row-AccessibilitySVGObject-AXCoreObject branch from e956b40 to 95e3cd6 Compare August 18, 2025 22:12
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 298860@main (95e3cd6): https://commits.webkit.org/298860@main

Reviewed commits have been landed. Closing PR #49524 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 95e3cd6 into WebKit:main Aug 18, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants