Skip to content

Handle unexpected disconnect of a game controller in UIGamepadProvider#49768

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
aperezdc:non-cocoa-log-gamepad-disconnect
Aug 22, 2025
Merged

Handle unexpected disconnect of a game controller in UIGamepadProvider#49768
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
aperezdc:non-cocoa-log-gamepad-disconnect

Conversation

@aperezdc
Copy link
Copy Markdown
Contributor

@aperezdc aperezdc commented Aug 22, 2025

5a86de2

Handle unexpected disconnect of a game controller in UIGamepadProvider
https://bugs.webkit.org/show_bug.cgi?id=297595

Reviewed by Carlos Garcia Campos.

This is a follow-up to 298899@main that adds logging an error for
non-Cocoa platforms.

* Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::platformGamepadDisconnected): Log an error
on unexpected gamepad disconnections.

Canonical link: https://commits.webkit.org/299052@main

fc40671

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aperezdc aperezdc requested a review from cdumez as a code owner August 22, 2025 12:52
@aperezdc aperezdc self-assigned this Aug 22, 2025
@aperezdc aperezdc added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Aug 22, 2025
@aperezdc aperezdc requested a review from a team August 22, 2025 12:53
@aperezdc aperezdc added the GLib Suggested Backport - 2.50 Suggest this merge request be backported to webkitglib/2.50 branch label Aug 22, 2025
@aperezdc aperezdc added the merge-queue Applied to send a pull request to merge-queue label Aug 22, 2025
https://bugs.webkit.org/show_bug.cgi?id=297595

Reviewed by Carlos Garcia Campos.

This is a follow-up to 298899@main that adds logging an error for
non-Cocoa platforms.

* Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::platformGamepadDisconnected): Log an error
on unexpected gamepad disconnections.

Canonical link: https://commits.webkit.org/299052@main
@webkit-commit-queue webkit-commit-queue force-pushed the non-cocoa-log-gamepad-disconnect branch from fc40671 to 5a86de2 Compare August 22, 2025 13:53
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 299052@main (5a86de2): https://commits.webkit.org/299052@main

Reviewed commits have been landed. Closing PR #49768 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5a86de2 into WebKit:main Aug 22, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 22, 2025
@aperezdc aperezdc deleted the non-cocoa-log-gamepad-disconnect branch August 22, 2025 22:46
@aperezdc
Copy link
Copy Markdown
Contributor Author

Backported into webkitglib/2.50 as commit 563fe07

@aperezdc aperezdc removed the GLib Suggested Backport - 2.50 Suggest this merge request be backported to webkitglib/2.50 branch label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants