[WebGPU] Add mechanism for automatically generated reductions for compilation failures#50079
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Sep 1, 2025
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 322c03a) Details |
322c03a to
9cf1b53
Compare
Collaborator
|
EWS run on previous version of this PR (hash 9cf1b53) Details |
tadeuzagallo
approved these changes
Sep 1, 2025
9cf1b53 to
11e11ac
Compare
Collaborator
|
EWS run on current version of this PR (hash 11e11ac) Details |
…pilation failures https://bugs.webkit.org/show_bug.cgi?id=297966 rdar://159286376 Reviewed by Tadeu Zagallo. Generate a C++ reduction when a PSO compilation fails that we would otherwise expect to succeed. * Source/WebGPU/WebGPU/ComputePipeline.mm: (WebGPU::createComputePipelineState): * Source/WebGPU/WebGPU/Pipeline.h: * Source/WebGPU/WebGPU/Pipeline.mm: (WebGPU::createLibrary): (WebGPU::printPsoOnProgramExit): (WebGPU::registerPsoExitHandlers): (WebGPU::printToFileForPsoRepro): (WebGPU::dumpMetalReproCaseComputePSO): (WebGPU::dumpMetalReproCaseRenderPSO): (WebGPU::clearMetalPSORepro): * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::createVertexDescriptor): Canonical link: https://commits.webkit.org/299410@main
11e11ac to
f6b4c56
Compare
Collaborator
|
Committed 299410@main (f6b4c56): https://commits.webkit.org/299410@main Reviewed commits have been landed. Closing PR #50079 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f6b4c56
11e11ac