Skip to content

[WebGPU] Add mechanism for automatically generated reductions for compilation failures#50079

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mwyrzykowski:eng/WebGPU-Add-mechanism-for-automatically-generated-reductions-for-compilation-failures
Sep 1, 2025
Merged

[WebGPU] Add mechanism for automatically generated reductions for compilation failures#50079
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mwyrzykowski:eng/WebGPU-Add-mechanism-for-automatically-generated-reductions-for-compilation-failures

Conversation

@mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Aug 29, 2025

f6b4c56

[WebGPU] Add mechanism for automatically generated reductions for compilation failures
https://bugs.webkit.org/show_bug.cgi?id=297966
rdar://159286376

Reviewed by Tadeu Zagallo.

Generate a C++ reduction when a PSO compilation fails that we would
otherwise expect to succeed.

* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::createComputePipelineState):
* Source/WebGPU/WebGPU/Pipeline.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createLibrary):
(WebGPU::printPsoOnProgramExit):
(WebGPU::registerPsoExitHandlers):
(WebGPU::printToFileForPsoRepro):
(WebGPU::dumpMetalReproCaseComputePSO):
(WebGPU::dumpMetalReproCaseRenderPSO):
(WebGPU::clearMetalPSORepro):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::createVertexDescriptor):

Canonical link: https://commits.webkit.org/299410@main

11e11ac

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Aug 29, 2025
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Aug 29, 2025
@mwyrzykowski mwyrzykowski requested a review from heycam August 29, 2025 19:36
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-Add-mechanism-for-automatically-generated-reductions-for-compilation-failures branch from 322c03a to 9cf1b53 Compare August 29, 2025 21:53
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-Add-mechanism-for-automatically-generated-reductions-for-compilation-failures branch from 9cf1b53 to 11e11ac Compare September 1, 2025 16:36
@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Sep 1, 2025
…pilation failures

https://bugs.webkit.org/show_bug.cgi?id=297966
rdar://159286376

Reviewed by Tadeu Zagallo.

Generate a C++ reduction when a PSO compilation fails that we would
otherwise expect to succeed.

* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::createComputePipelineState):
* Source/WebGPU/WebGPU/Pipeline.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createLibrary):
(WebGPU::printPsoOnProgramExit):
(WebGPU::registerPsoExitHandlers):
(WebGPU::printToFileForPsoRepro):
(WebGPU::dumpMetalReproCaseComputePSO):
(WebGPU::dumpMetalReproCaseRenderPSO):
(WebGPU::clearMetalPSORepro):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::createVertexDescriptor):

Canonical link: https://commits.webkit.org/299410@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Add-mechanism-for-automatically-generated-reductions-for-compilation-failures branch from 11e11ac to f6b4c56 Compare September 1, 2025 21:59
@webkit-commit-queue
Copy link
Collaborator

Committed 299410@main (f6b4c56): https://commits.webkit.org/299410@main

Reviewed commits have been landed. Closing PR #50079 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f6b4c56 into WebKit:main Sep 1, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments