Skip to content

REGRESSION(299308@main) [GTK] GTK3 build broken due to missing AddEventListenerOptionsInlines.h includes#50165

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
lauromoura:eng/REGRESSION-299308-main-GTK-GTK3-build-broken-due-to-missing-AddEventListenerOptionsInlines-h-includes
Sep 2, 2025
Merged

REGRESSION(299308@main) [GTK] GTK3 build broken due to missing AddEventListenerOptionsInlines.h includes#50165
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
lauromoura:eng/REGRESSION-299308-main-GTK-GTK3-build-broken-due-to-missing-AddEventListenerOptionsInlines-h-includes

Conversation

@lauromoura
Copy link
Copy Markdown
Contributor

@lauromoura lauromoura commented Sep 2, 2025

5a11c36

REGRESSION(299308@main) [GTK] GTK3 build broken due to missing AddEventListenerOptionsInlines.h includes
https://bugs.webkit.org/show_bug.cgi?id=298207

Unreviewed build fix.

Round 2 of adding the missing includes. This time tested locally.

* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMAttr.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCharacterData.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMFileList.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLCanvasElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFieldSetElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHtmlElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMapElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptionElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLSelectElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTextAreaElement.cpp:

Canonical link: https://commits.webkit.org/299419@main

0fd0dec

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lauromoura lauromoura requested review from a team and cdumez as code owners September 2, 2025 03:39
@lauromoura lauromoura self-assigned this Sep 2, 2025
@lauromoura lauromoura added the WebKitGTK Bugs related to the Gtk API layer. label Sep 2, 2025
@lauromoura lauromoura force-pushed the eng/REGRESSION-299308-main-GTK-GTK3-build-broken-due-to-missing-AddEventListenerOptionsInlines-h-includes branch from 4bf159c to 0fd0dec Compare September 2, 2025 03:42
@lauromoura lauromoura added the merge-queue Applied to send a pull request to merge-queue label Sep 2, 2025
…ntListenerOptionsInlines.h includes

https://bugs.webkit.org/show_bug.cgi?id=298207

Unreviewed build fix.

Round 2 of adding the missing includes. This time tested locally.

* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMAttr.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCharacterData.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMFileList.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLCanvasElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFieldSetElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHtmlElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMapElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptionElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLSelectElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTextAreaElement.cpp:

Canonical link: https://commits.webkit.org/299419@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-299308-main-GTK-GTK3-build-broken-due-to-missing-AddEventListenerOptionsInlines-h-includes branch from 0fd0dec to 5a11c36 Compare September 2, 2025 04:47
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 299419@main (5a11c36): https://commits.webkit.org/299419@main

Reviewed commits have been landed. Closing PR #50165 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5a11c36 into WebKit:main Sep 2, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 2, 2025
@lauromoura lauromoura deleted the eng/REGRESSION-299308-main-GTK-GTK3-build-broken-due-to-missing-AddEventListenerOptionsInlines-h-includes branch September 8, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants