Skip to content

[Filters] Applying CoreGraphics filters on different tiles may result in white borders around the tiles #50371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

[Filters] Applying CoreGraphics filters on different tiles may result in white borders around the tiles #50371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions LayoutTests/css3/filters/effect-graphics-context-blur-tile-boundaries-expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="resources/filter-helpers.css">
<style>
img {
transform: translate(400%, 400%) scale(8, 8);
}
</style>
</head>
<body>
<img src="resources/reference.png" style="filter: blur(5px)">
</body>
</html>
19 changes: 19 additions & 0 deletions LayoutTests/css3/filters/effect-graphics-context-blur-tile-boundaries.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html>
<html>
<head>
<meta name="fuzzy" content="maxDifference=0-16; totalPixels=0-452017" />
<link rel="stylesheet" href="resources/filter-helpers.css">
<style>
img {
transform: translate(400%, 400%) scale(8, 8);
}
</style>
</head>
<script>
if (window.internals)
internals.settings.setGraphicsContextBlurFilterEnabled?.(true);
</script>
<body>
<img src="resources/reference.png" style="filter: blur(5px)">
</body>
</html>
2 changes: 2 additions & 0 deletions Source/WebCore/rendering/LayerFragment.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class LayerFragment {

LayoutRect layerBounds() const { return m_layerBounds; }

ClipRect backgroundRect() const { return m_backgroundRect; }
ClipRect dirtyBackgroundRect() const { return intersection(m_paintDirtyRect, m_backgroundRect); }
ClipRect dirtyForegroundRect() const { return intersection(m_paintDirtyRect, m_foregroundRect); }

Expand Down Expand Up @@ -93,6 +94,7 @@ class LayerFragment {

LayoutRect layerBounds() const { return rects.layerBounds(); }

ClipRect backgroundRect() const { return rects.backgroundRect(); }
ClipRect dirtyBackgroundRect() const { return rects.dirtyBackgroundRect(); }
ClipRect dirtyForegroundRect() const { return rects.dirtyForegroundRect(); }

Expand Down
2 changes: 1 addition & 1 deletion Source/WebCore/rendering/RenderLayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3879,7 +3879,7 @@ void RenderLayer::paintLayerContents(GraphicsContext& context, const LayerPainti
updatePaintingInfoForFragments(layerFragments, paintingInfo, localPaintFlags, shouldPaintContent, offsetFromRoot);

// FIXME: Handle more than one fragment.
backgroundRect = layerFragments.isEmpty() ? ClipRect() : layerFragments[0].dirtyBackgroundRect();
backgroundRect = layerFragments.isEmpty() ? ClipRect() : layerFragments[0].backgroundRect();

if (haveTransparency) {
// If we have a filter and transparency, we have to eagerly start a transparency layer here, rather than risk a child layer lazily starts one with the wrong context.
Expand Down