-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WebDriver][BiDi] Implement the browsingContext.captureScreenshot command #50590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AnujPanta1
wants to merge
1
commit into
WebKit:main
Choose a base branch
from
AnujPanta1:eng/137019047
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
EWS run on previous version of this PR (hash a188687)
|
a188687 to
c7c0611
Compare
Collaborator
|
EWS run on previous version of this PR (hash c7c0611) |
burg
requested changes
Sep 15, 2025
Contributor
burg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good WIP so far!
Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.cpp
Outdated
Show resolved
Hide resolved
Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.cpp
Outdated
Show resolved
Hide resolved
c7c0611 to
cefb322
Compare
Collaborator
|
EWS run on previous version of this PR (hash cefb322) |
…mand https://bugs.webkit.org/show_bug.cgi?id=288325 rdar://145987196 Reviewed by NOBODY (OOPS!). Adds captureScreenshot support to capture screenshots of browsing contexts with rectangle clipping and format options. Uses existing WebAutomationSession screenshot infrastructure. Needs additional work surrounding supporting all origins, formatting options, and element reference resolutions. * Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.cpp: (WebKit::BidiBrowsingContextAgent::captureScreenshot): (WebKit::BidiBrowsingContextAgent::getOriginRectangle): (WebKit::BidiBrowsingContextAgent::normalizeRect): (WebKit::BidiBrowsingContextAgent::rectangleIntersection): (WebKit::BidiBrowsingContextAgent::parseClipRectangle): (WebKit::BidiBrowsingContextAgent::parseBoxClipRectangle): (WebKit::BidiBrowsingContextAgent::parseElementClipRectangle): (WebKit::BidiBrowsingContextAgent::performScreenshotCapture): (WebKit::BidiBrowsingContextAgent::parseImageFormatType): (WebKit::BidiBrowsingContextAgent::imageFormatTypeToString): (WebKit::BidiBrowsingContextAgent::convertImageFormat const): * Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.h: * Source/WebKit/UIProcess/Automation/protocol/BidiBrowsingContext.json: * Source/WebKit/UIProcess/Automation/protocol/BidiScript.json:
cefb322 to
5123b3a
Compare
Collaborator
|
EWS run on current version of this PR (hash 5123b3a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 🧪 jsc
5123b3a
5123b3a
🛠 playstation