[MiniBrowser] [macOS] Users should be able to focus form controls with tab key navigation#50689
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Sep 13, 2025
Merged
Conversation
aprotyas
added
the
Tools / Tests
Collaborator
|
EWS run on previous version of this PR (hash b1948d1) Details
|
pxlcoder
approved these changes
Sep 13, 2025
aprotyas
force-pushed
the
eng/298806
branch
from
b1948d1 to
286921d
Compare
Collaborator
|
EWS run on current version of this PR (hash 286921d) Details
|
Member
Author
|
Thanks for the review! |
aprotyas
added
the
unsafe-merge-queue
…h tab key navigation https://bugs.webkit.org/show_bug.cgi?id=298806 rdar://160504199 Reviewed by Aditya Keerthi. This patch introduces a toggle in MiniBrowser that plumbs into `WKPreferences.tabFocusesLinks`, allowing users to focus links and form controls through tab key navigation, akin to Safari's "Press Tab to highlight each item on a webpage" preference. * Tools/MiniBrowser/mac/SettingsController.h: * Tools/MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu:]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleTabFocusesLinksEnabled:]): (-[SettingsController tabFocusesLinksEnabled]): * Tools/MiniBrowser/mac/WK1BrowserWindowController.m: (-[WK1BrowserWindowController didChangeSettings]): * Tools/MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): Canonical link: https://commits.webkit.org/299923@main
webkit-commit-queue
force-pushed
the
eng/298806
branch
from
286921d to
a2cf34f
Compare
Collaborator
|
Committed 299923@main (a2cf34f): https://commits.webkit.org/299923@main Reviewed commits have been landed. Closing PR #50689 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a2cf34f
286921d
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 mac-wk2-stress🧪 vision-wk2🧪 mac-intel-wk2🛠 playstation🛠 tv-sim🛠 watch-sim