-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove non-standard overflowchanged
#50833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-standard overflowchanged
#50833
Conversation
|
EWS run on previous version of this PR (hash 7e281dd) Details |
overflowchangedoverflowchanged https://bugs.webkit.org/show_bug.cgi?id=218402 rdar://71129110
7e281dd to
c123980
Compare
|
EWS run on previous version of this PR (hash c123980) Details
|
c123980 to
ef60dc7
Compare
|
EWS run on previous version of this PR (hash ef60dc7) Details
|
overflowchanged https://bugs.webkit.org/show_bug.cgi?id=218402 rdar://71129110overflowchanged
ef60dc7 to
8648c4d
Compare
|
EWS run on previous version of this PR (hash 8648c4d) Details |
Safer C++ Build #53737 (8648c4d)
|
8648c4d to
5202e89
Compare
|
EWS run on current version of this PR (hash 5202e89) Details |
https://bugs.webkit.org/show_bug.cgi?id=218402 rdar://71129110 Reviewed by Simon Fraser. This landed in past 281672@main but got reverted on assumption of causing regression on webmail.biglobe.ne.jp in 289380@main but it seems the website claims on blog news post that it is still broken in iOS 26 [1]. So this was not cause of regression, so this is second attempt to land this. [1] https://support.biglobe.ne.jp/news/news752.html (Use Translation) This patch aligns WebKit with Gecko / Firefox, Blink / Chromium by removing non-standard `overflowchanged`. It was removed from Blink in 2015 [2]: [2] chromium/chromium@86665f6 It was never supported by Gecko / Firefox. * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/dom/Document.cpp: (WebCore::Document::createEvent): (WebCore::Document::addListenerTypeIfNeeded): (WebCore::Document::enqueueOverflowEvent): Deleted. * Source/WebCore/dom/Document.h: * Source/WebCore/dom/EventInterfaces.in: * Source/WebCore/dom/EventNames.json: * Source/WebCore/dom/OverflowEvent.cpp: Removed. * Source/WebCore/dom/OverflowEvent.h: Removed. * Source/WebCore/dom/OverflowEvent.idl: Removed. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::didLayout): (WebCore::LocalFrameView::updateOverflowStatus): Deleted. * Source/WebCore/page/LocalFrameView.h: * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::layout): (WebCore::OverflowEventDispatcher::OverflowEventDispatcher): Deleted. (WebCore::OverflowEventDispatcher::~OverflowEventDispatcher): Deleted. * Source/WebCore/rendering/RenderLayer.cpp: * Source/WebKitLegacy/mac/DOM/DOMEvents.mm: (kitClass): * Source/WebKitLegacy/mac/DOM/DOMOverflowEvent.mm: (-[DOMOverflowEvent orient]): (-[DOMOverflowEvent horizontalOverflow]): (-[DOMOverflowEvent verticalOverflow]): (-[DOMOverflowEvent initOverflowEvent:horizontalOverflow:verticalOverflow:]): > Test Updates / Removals: * LayoutTests/fast/dom/Window/resources/window-properties.js: * LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt: * LayoutTests/fast/dom/wrapper-classes-expected.txt: * LayoutTests/fast/dom/wrapper-classes.html: * LayoutTests/fast/dynamic/paused-event-dispatch-expected.txt: Removed. * LayoutTests/fast/dynamic/paused-event-dispatch.html: Removed. * LayoutTests/fast/dynamic/resources/paused-event-dispatch-iframe.html: Removed. * LayoutTests/fast/events/change-overflow-on-overflow-change-expected.txt: Removed. * LayoutTests/fast/events/change-overflow-on-overflow-change.html: Removed. * LayoutTests/fast/events/constructors/overflow-event-constructor-expected.txt: Removed. * LayoutTests/fast/events/constructors/overflow-event-constructor.html: Removed. * LayoutTests/fast/events/event-creation-expected.txt: * LayoutTests/fast/events/event-creation.html: * LayoutTests/fast/events/overflow-events-expected.txt: Removed. * LayoutTests/fast/events/overflow-events-writing-mode-expected.txt: Removed. * LayoutTests/fast/events/overflow-events-writing-mode.html: Removed. * LayoutTests/fast/events/overflow-events.html: Removed. * LayoutTests/fast/events/overflow-viewport-renderer-deleted.html: Removed. * LayoutTests/fast/events/overflowchanged-inside-selection-collapse-crash-expected.txt: Removed. * LayoutTests/fast/events/overflowchanged-inside-selection-collapse-crash.html: Removed. * LayoutTests/fast/overflow/horizontal-overflow-with-offset-expected.txt: Removed. * LayoutTests/fast/overflow/horizontal-overflow-with-offset.html: Removed. * LayoutTests/fast/overflow/vertical-overflow-with-offset-expected.txt: Removed. * LayoutTests/fast/overflow/vertical-overflow-with-offset.html: Removed. * LayoutTests/js/dom/constructor-length.html: * LayoutTests/platform/glib/fast/dom/Window/window-lookup-precedence-expected.txt: * LayoutTests/platform/glib/js/dom/constructor-length-expected.txt: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/js/dom/constructor-length-expected.txt: * LayoutTests/platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt: * LayoutTests/platform/mac/fast/dom/wrapper-classes-objc-expected.txt: * LayoutTests/platform/mac/fast/dom/wrapper-classes-objc.html: * LayoutTests/platform/mac/js/dom/constructor-length-expected.txt: * LayoutTests/platform/win/js/dom/constructor-length-expected.txt: > SafeCPP Expectation Updates: * Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations: Canonical link: https://commits.webkit.org/300125@main
5202e89 to
55f58b7
Compare
|
Committed 300125@main (55f58b7): https://commits.webkit.org/300125@main Reviewed commits have been landed. Closing PR #50833 and removing active labels. |
55f58b7
5202e89
🧪 win-tests