[GTK][WPE] font-size-adjust:0 and SVG Font failures#51038
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Sep 22, 2025
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash b3f7581) Details |
b3f7581 to
6e7b5a6
Compare
Collaborator
|
EWS run on previous version of this PR (hash 6e7b5a6) Details |
6e7b5a6 to
0fcf58a
Compare
Collaborator
|
EWS run on current version of this PR (hash 0fcf58a) Details |
carlosgcampos
approved these changes
Sep 22, 2025
https://bugs.webkit.org/show_bug.cgi?id=290449 Reviewed by Carlos Garcia Campos. If the given font lacks the required glyphs, a system fallback font is created. Previously, the fallback font was initialized with the computed size, which caused failures in tests using font fallback with font-size-adjust. To fix this, we now apply font-size-adjust when setting the size of the fallback font. Test: imported/w3c/web-platform-tests/svg/fonts/zero-font-size-adjust-no-glyphs-font.html imported/w3c/web-platform-tests/svg/fonts/zero-font-size-adjust-no-glyphs-zero-height-font.html imported/w3c/web-platform-tests/svg/fonts/zero-font-size-adjust.html * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: (WebCore::FontCache::systemFallbackForCharacterCluster): Canonical link: https://commits.webkit.org/300335@main
0fcf58a to
7146a8c
Compare
Collaborator
|
Committed 300335@main (7146a8c): https://commits.webkit.org/300335@main Reviewed commits have been landed. Closing PR #51038 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7146a8c
0fcf58a