Skip to content

[JSC] --jitMemoryReservationSize should be larger in debug test#51431

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Constellation:eng/JSC-jitMemoryReservationSize-should-be-larger-in-debug-test
Sep 29, 2025
Merged

[JSC] --jitMemoryReservationSize should be larger in debug test#51431
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Constellation:eng/JSC-jitMemoryReservationSize-should-be-larger-in-debug-test

Conversation

@Constellation
Copy link
Member

@Constellation Constellation commented Sep 27, 2025

@Constellation Constellation self-assigned this Sep 27, 2025
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Sep 27, 2025
@Constellation Constellation requested a review from a team September 27, 2025 17:16
@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 29, 2025
https://bugs.webkit.org/show_bug.cgi?id=299653
rdar://161457834

Reviewed by Dan Hecht.

Debug build emits a lot of additional JIT code for debugging.
This patch uses larger size for --jitMemoryReservationSize
when test type is debug.

* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/300697@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-jitMemoryReservationSize-should-be-larger-in-debug-test branch from b6c1bef to bd3e685 Compare September 29, 2025 16:09
@webkit-commit-queue
Copy link
Collaborator

Committed 300697@main (bd3e685): https://commits.webkit.org/300697@main

Reviewed commits have been landed. Closing PR #51431 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bd3e685 into WebKit:main Sep 29, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants