-
Notifications
You must be signed in to change notification settings - Fork 1.8k
vp9HardwareDecoderAvailable() is non-functional when called in the content process. #51487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
EWS run on previous version of this PR (hash dd044b2) Details |
|
|
||
| return canLoad_VideoToolbox_VTIsHardwareDecodeSupported() && VTIsHardwareDecodeSupported(kCMVideoCodecType_VP9); | ||
| if (canLoad_VideoToolbox_VTIsHardwareDecodeSupported() && VTIsHardwareDecodeSupported(kCMVideoCodecType_VP9)) | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would tend to revert the calls (if we have an override use it, otherwise call VT).
|
|
||
| void VP9TestingOverrides::setVP9HardwareDecoderEnabledOverride(std::optional<bool>&& disabled) | ||
| { | ||
| m_vp9HardwareDecoderEnabledOverride = WTFMove(disabled); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| m_vp9HardwareDecoderEnabledOverride = WTFMove(disabled); | |
| ASSERT(! m_vp9HardwareDecoderEnabledOverride); | |
| m_vp9HardwareDecoderEnabledOverride = WTFMove(disabled); |
dd044b2 to
322d5b8
Compare
|
EWS run on current version of this PR (hash 322d5b8) Details |
…ntent process. https://bugs.webkit.org/show_bug.cgi?id=299710 rdar://161534911 Reviewed by Youenn Fablet. We re-use the VP9TestingOverrides structure to be able to store if we the VP9 HW decoder is available. When the value of GPUProcessConnectionInfo::hasVP9HardwareDecoder is retrieved, we set it to VP9TestingOverrides. This allows to enable the SourceBufferParserWebM to work in the content process. * Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h: * Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm: (WebCore::VP9TestingOverrides::setVP9HardwareDecoderEnabledOverride): (WebCore::vp9HardwareDecoderAvailable): * Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp: (WebKit::GPUProcessConnection::didInitialize): Canonical link: https://commits.webkit.org/300722@main
322d5b8 to
0bdf4bc
Compare
|
Committed 300722@main (0bdf4bc): https://commits.webkit.org/300722@main Reviewed commits have been landed. Closing PR #51487 and removing active labels. |
🛠 mac-apple
0bdf4bc
322d5b8
🧪 win-tests🛠 playstation