Skip to content

Fix new Clang 21 warnings#51520

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mcatanzaro:eng/Fix-new-Clang-21-warnings
Sep 29, 2025
Merged

Fix new Clang 21 warnings#51520
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mcatanzaro:eng/Fix-new-Clang-21-warnings

Conversation

@mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Sep 29, 2025

@mcatanzaro mcatanzaro requested a review from philn as a code owner September 29, 2025 20:23
@mcatanzaro mcatanzaro self-assigned this Sep 29, 2025
@mcatanzaro mcatanzaro added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Sep 29, 2025
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Sep 29, 2025
https://bugs.webkit.org/show_bug.cgi?id=299820

Reviewed by Yusuke Suzuki.

This mostly fixes -Wunnecessary-virtual-specifier warnings (virtual
method is inside a 'final' class and can never be overridden). There is
also one -Wsometimes-uninitialized warning fixed by using
RELEASE_ASSERT_NOT_REACHED() to ensure the compiler knows the code
supposed to be unreachable.

Canonical link: https://commits.webkit.org/300714@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-new-Clang-21-warnings branch from 89c687e to 8516f76 Compare September 29, 2025 21:33
@webkit-commit-queue
Copy link
Collaborator

Committed 300714@main (8516f76): https://commits.webkit.org/300714@main

Reviewed commits have been landed. Closing PR #51520 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8516f76 into WebKit:main Sep 29, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants