Fix new Clang 21 warnings#51520
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Sep 29, 2025
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 89c687e) Details |
Constellation
approved these changes
Sep 29, 2025
https://bugs.webkit.org/show_bug.cgi?id=299820 Reviewed by Yusuke Suzuki. This mostly fixes -Wunnecessary-virtual-specifier warnings (virtual method is inside a 'final' class and can never be overridden). There is also one -Wsometimes-uninitialized warning fixed by using RELEASE_ASSERT_NOT_REACHED() to ensure the compiler knows the code supposed to be unreachable. Canonical link: https://commits.webkit.org/300714@main
89c687e to
8516f76
Compare
Collaborator
|
Committed 300714@main (8516f76): https://commits.webkit.org/300714@main Reviewed commits have been landed. Closing PR #51520 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8516f76
89c687e
🛠 win🧪 wpe-wk2🧪 win-tests🧪 api-wpe🧪 gtk-wk2🛠 playstation🛠 watch🛠 watch-sim