Skip to content

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Oct 10, 2025

@cdumez cdumez self-assigned this Oct 10, 2025
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Oct 10, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2025
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2025
@cdumez cdumez force-pushed the 300501_drop_std_aligned_storage branch from a8faf5e to 0682336 Compare October 10, 2025 12:02
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2025
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2025
@cdumez cdumez force-pushed the 300501_drop_std_aligned_storage branch from 0682336 to 8fc4fd8 Compare October 10, 2025 12:09
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safer C++ Build #58059 (a8faf5e)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WTF --MemoryUnsafeCastChecker wtf/ThreadSpecific.h

@webkit-ews-buildbot
Copy link
Collaborator

Safer C++ Build #58066 (0682336)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WTF --MemoryUnsafeCastChecker wtf/ThreadSpecific.h

@webkit-ews-buildbot
Copy link
Collaborator

Safer C++ Build #58068 (8fc4fd8)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WTF --MemoryUnsafeCastChecker wtf/ThreadSpecific.h

@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2025
@cdumez cdumez force-pushed the 300501_drop_std_aligned_storage branch from 8fc4fd8 to fb2f6d7 Compare October 10, 2025 14:05
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safer C++ Build #58076 (fb2f6d7)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WTF --MemoryUnsafeCastChecker wtf/ThreadSpecific.h

@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 11, 2025
@cdumez cdumez force-pushed the 300501_drop_std_aligned_storage branch from fb2f6d7 to 6e17dcb Compare October 11, 2025 01:23
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 11, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safer C++ Build #58173 (6e17dcb)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WTF --MemoryUnsafeCastChecker wtf/ThreadSpecific.h

@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 11, 2025
@cdumez cdumez force-pushed the 300501_drop_std_aligned_storage branch from 6e17dcb to d5bd038 Compare October 11, 2025 08:15
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 11, 2025
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 11, 2025
@cdumez cdumez force-pushed the 300501_drop_std_aligned_storage branch from d5bd038 to 9515d82 Compare October 11, 2025 08:53
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 11, 2025
@cdumez cdumez marked this pull request as ready for review October 12, 2025 22:26
@cdumez cdumez requested a review from a team as a code owner October 12, 2025 22:26
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 12, 2025
@cdumez cdumez requested review from darinadler, rniwa and weinig October 12, 2025 22:27
typedef typename std::aligned_storage<s_pageSize, std::alignment_of<uintptr_t>::value>::type Buffer;
ALLOW_DEPRECATED_DECLARATIONS_END
Buffer m_buffer;
alignas(std::alignment_of<uintptr_t>::value) std::byte m_buffer[s_pageSize];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need std::alignment_of... part? Doesn't alignas(uintptr_t) work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does work. I'll fix, thanks.

#define DECLARE_STATIC_PER_PROCESS_STORAGE_WITH_LINKAGE(Type, Linkage) \
template<> struct StaticPerProcessStorageTraits<Type> { \
using Memory = typename std::aligned_storage<sizeof(Type), std::alignment_of<Type>::value>::type; \
struct alignas(alignof(Type)) Memory { \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignas(Type)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixing.

@cdumez cdumez force-pushed the 300501_drop_std_aligned_storage branch from 9515d82 to a9dc36a Compare October 13, 2025 01:00
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 13, 2025
https://bugs.webkit.org/show_bug.cgi?id=300501

Reviewed by Yusuke Suzuki and Ryosuke Niwa.

* Source/JavaScriptCore/assembler/ProbeStack.h:
* Source/WTF/wtf/SizeLimits.cpp:
* Source/WebKit/Shared/Cocoa/APIObject.mm:
* Source/bmalloc/bmalloc/PerHeapKind.h:
(bmalloc::PerHeapKindBase::at const):
* Source/bmalloc/bmalloc/StaticPerProcess.h:

Canonical link: https://commits.webkit.org/301389@main
@webkit-commit-queue webkit-commit-queue force-pushed the 300501_drop_std_aligned_storage branch from a9dc36a to 0833418 Compare October 13, 2025 02:33
@webkit-commit-queue
Copy link
Collaborator

Committed 301389@main (0833418): https://commits.webkit.org/301389@main

Reviewed commits have been landed. Closing PR #52115 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0833418 into WebKit:main Oct 13, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants