Skip to content

[iOS][WebContent] Block iopolicysys syscall in sandbox#52241

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
pvollan:eng/iOS-WebContent-Block-iopolicysys-syscall-in-sandbox
Oct 14, 2025
Merged

[iOS][WebContent] Block iopolicysys syscall in sandbox#52241
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
pvollan:eng/iOS-WebContent-Block-iopolicysys-syscall-in-sandbox

Conversation

@pvollan
Copy link
Contributor

@pvollan pvollan commented Oct 13, 2025

6b5ffb6

[iOS][WebContent] Block iopolicysys syscall in sandbox
https://bugs.webkit.org/show_bug.cgi?id=300630
rdar://162528753

Reviewed by Brent Fulgham.

This syscall is rarely used, and the client is handling the blocking gracefully, so it can be blocked.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.Development.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Shared/Sandbox/iOS/webcontent-defines.sb:

Canonical link: https://commits.webkit.org/301474@main

2118730

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan requested a review from brentfulgham as a code owner October 13, 2025 15:10
@pvollan pvollan self-assigned this Oct 13, 2025
@pvollan pvollan added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Oct 13, 2025
@pvollan pvollan requested review from cdumez and szewai October 13, 2025 15:11
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. r=me.

Please consider filing a reminder bug to remove the telemetry once we're confident this change will stay permanently.

(deny file-write-mount file-write-unmount)

(deny process-iopolicy-get (with telemetry))
(deny process-iopolicy-set (with telemetry))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we file a bug to remind ourselves to remove this telemetry once we've captured enough live-on time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll file a bug for that.

Thanks for reviewing!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2025
https://bugs.webkit.org/show_bug.cgi?id=300630
rdar://162528753

Reviewed by Brent Fulgham.

This syscall is rarely used, and the client is handling the blocking gracefully, so it can be blocked.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.Development.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Shared/Sandbox/iOS/webcontent-defines.sb:

Canonical link: https://commits.webkit.org/301474@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/iOS-WebContent-Block-iopolicysys-syscall-in-sandbox branch from 2118730 to 6b5ffb6 Compare October 14, 2025 13:48
@webkit-commit-queue
Copy link
Collaborator

Committed 301474@main (6b5ffb6): https://commits.webkit.org/301474@main

Reviewed commits have been landed. Closing PR #52241 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6b5ffb6 into WebKit:main Oct 14, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Process Model Bugs related to WebKit's multi-process architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants