Make method to set LayoutRect/FloatRect via edge coordinates public#52414
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 16, 2025
Merged
Make method to set LayoutRect/FloatRect via edge coordinates public#52414webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on current version of this PR (hash 27ae8d7) Details
|
smfr
approved these changes
Oct 15, 2025
27ae8d7 to
8f1698f
Compare
https://bugs.webkit.org/show_bug.cgi?id=300826 rdar://162710333 Reviewed by Simon Fraser. Shifts the setLocationAndSizeFromEdges() method from private to public and renames it to shiftEdgesTo() to align with the various shift*EdgeTo() methods. Also adds the two missing shift*EdgeBy() methods to LayoutRect. * Source/WebCore/platform/graphics/FloatRect.cpp: (WebCore::FloatRect::intersect): (WebCore::FloatRect::uniteEvenIfEmpty): (WebCore::FloatRect::extend): * Source/WebCore/platform/graphics/FloatRect.h: (WebCore::FloatRect::shiftEdgesTo): (WebCore::FloatRect::setLocationAndSizeFromEdges): Deleted. * Source/WebCore/platform/graphics/LayoutRect.cpp: (WebCore::LayoutRect::uniteEvenIfEmpty): * Source/WebCore/platform/graphics/LayoutRect.h: (WebCore::LayoutRect::shiftEdgesTo): (WebCore::LayoutRect::setLocationAndSizeFromEdges): Deleted. Canonical link: https://commits.webkit.org/301603@main
8f1698f to
680f94c
Compare
Collaborator
|
Committed 301603@main (680f94c): https://commits.webkit.org/301603@main Reviewed commits have been landed. Closing PR #52414 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
680f94c
27ae8d7
🧪 win-tests🧪 api-ios