[macOS 26] TestWebKitAPI.FontManagerTests.ChangeAttributesWithFontEffectsBox fails due to changes in NSFontPanel#52886
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 23, 2025
Conversation
Collaborator
|
EWS run on current version of this PR (hash eb2286e) Details |
pxlcoder
approved these changes
Oct 23, 2025
Member
Author
|
Thanks for the review! |
…ectsBox fails due to changes in NSFontPanel https://bugs.webkit.org/show_bug.cgi?id=301352 rdar://163133860 Reviewed by Aditya Keerthi. Since macOS 26, parts of the `NSFontPanel` UI have been reimplemented in Swift, or otherwise changed so that styling options are now behind popovers and menus. As a result, all of the popup buttons previously found by looking for `NSFontPanel*ToolbarItem` no longer exist. This test currently tries (and fails) to interact with these nonexistent controls. Fix this by changing how these tests work, such that they directly change the `_attributesToAdd` and `_attributesToRemove` ivars that determine which text styles should be applied when calling into `-changeAttributes:`. * Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: * Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm: (TestWebKitAPI::TEST(FontManagerTests, ChangeAttributesWithFontEffectsBox)): * Tools/TestWebKitAPI/mac/NSFontPanelTesting.h: * Tools/TestWebKitAPI/mac/NSFontPanelTesting.mm: (-[NSBox _addAttribute:value:]): (-[NSBox _removeAttribute:]): (-[NSBox _clearAttributes]): Add helpers to directly add or remove text styling attributes. (-[NSFontPanel fontEffectsBox]): (-[NSFontPanel setUnderlineStyle:]): (-[NSFontPanel setStrikethroughStyle:]): (-[NSFontPanel setTextShadow:]): (-[NSFontPanel commitAttributeChanges]): (findMenuItemWithTitle): Deleted. (-[NSFontPanel chooseUnderlineMenuItemWithTitle:]): Deleted. (-[NSFontPanel chooseStrikeThroughMenuItemWithTitle:]): Deleted. (-[NSFontPanel toggleShadow]): Deleted. Canonical link: https://commits.webkit.org/302033@main
eb2286e to
114e809
Compare
Collaborator
|
Committed 302033@main (114e809): https://commits.webkit.org/302033@main Reviewed commits have been landed. Closing PR #52886 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
114e809
eb2286e
🧪 ios-wk2-wpt