Skip to content

Disable nullability completeness#52939

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
adetaylor:eng/Disable-nullability-completeness
Oct 28, 2025
Merged

Disable nullability completeness#52939
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
adetaylor:eng/Disable-nullability-completeness

Conversation

@adetaylor
Copy link
Contributor

@adetaylor adetaylor commented Oct 24, 2025

fb05a6d

Disable nullability completeness
https://bugs.webkit.org/show_bug.cgi?id=301411
rdar://163319634

Reviewed by Geoffrey Garen.

This disables the clang nullability completeness warning. Swift/C++ interop
requires us to label some APIs as _Nullable or _Nonnull, and this warning then
requires us to similarly annotate all the other APIs in the same file. This
leads to annotation proliferation, and when we're not careful this can even
become viral across multiple files if we expand macros to include these
annotations. This is not currently deemed helpful or beneficial for WebKit.
See Slack discussion at

https://webkit.slack.com/archives/CU64U6FDW/p1761239537764009
Canonical link: https://commits.webkit.org/302237@main

96ec33d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@adetaylor adetaylor requested a review from emw-apple as a code owner October 24, 2025 06:45
@adetaylor adetaylor self-assigned this Oct 24, 2025
@adetaylor adetaylor added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Oct 24, 2025
@adetaylor adetaylor added the merge-queue Applied to send a pull request to merge-queue label Oct 28, 2025
https://bugs.webkit.org/show_bug.cgi?id=301411
rdar://163319634

Reviewed by Geoffrey Garen.

This disables the clang nullability completeness warning. Swift/C++ interop
requires us to label some APIs as _Nullable or _Nonnull, and this warning then
requires us to similarly annotate all the other APIs in the same file. This
leads to annotation proliferation, and when we're not careful this can even
become viral across multiple files if we expand macros to include these
annotations. This is not currently deemed helpful or beneficial for WebKit.
See Slack discussion at

https://webkit.slack.com/archives/CU64U6FDW/p1761239537764009
Canonical link: https://commits.webkit.org/302237@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Disable-nullability-completeness branch from 96ec33d to fb05a6d Compare October 28, 2025 13:53
@webkit-commit-queue
Copy link
Collaborator

Committed 302237@main (fb05a6d): https://commits.webkit.org/302237@main

Reviewed commits have been landed. Closing PR #52939 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fb05a6d into WebKit:main Oct 28, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants