Disable nullability completeness#52939
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 28, 2025
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 96ec33d) Details |
geoffreygaren
approved these changes
Oct 27, 2025
https://bugs.webkit.org/show_bug.cgi?id=301411 rdar://163319634 Reviewed by Geoffrey Garen. This disables the clang nullability completeness warning. Swift/C++ interop requires us to label some APIs as _Nullable or _Nonnull, and this warning then requires us to similarly annotate all the other APIs in the same file. This leads to annotation proliferation, and when we're not careful this can even become viral across multiple files if we expand macros to include these annotations. This is not currently deemed helpful or beneficial for WebKit. See Slack discussion at https://webkit.slack.com/archives/CU64U6FDW/p1761239537764009 Canonical link: https://commits.webkit.org/302237@main
96ec33d to
fb05a6d
Compare
Collaborator
|
Committed 302237@main (fb05a6d): https://commits.webkit.org/302237@main Reviewed commits have been landed. Closing PR #52939 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fb05a6d
96ec33d