The audio player UI on inline audio controls is gigantic and clipped#53224
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 31, 2025
Conversation
Collaborator
|
EWS run on current version of this PR (hash 72f739b) Details |
jernoble
approved these changes
Oct 30, 2025
https://bugs.webkit.org/show_bug.cgi?id=301718 rdar://163643539 Reviewed by Jer Noble. Add :not(.audio) selector in the macOSInlineMediaControlsStyleSheet and macos-inline-media-controls.js to avoid changing the appearnace of the mac inline audio controls. * Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js: (MacOSInlineMediaControls.prototype._setupVolumeSliderConfiguration): (MacOSInlineMediaControls.prototype.layout): (MacOSInlineMediaControls.prototype.handleEvent): (MacOSInlineMediaControls.prototype.rightContainerButtons): (MacOSInlineMediaControls): * Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm: (WebCore::macOSInlineMediaControlsStyleSheet): Canonical link: https://commits.webkit.org/302396@main
72f739b to
3010259
Compare
Collaborator
|
Committed 302396@main (3010259): https://commits.webkit.org/302396@main Reviewed commits have been landed. Closing PR #53224 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 win
3010259
72f739b
🛠 playstation