Skip to content

The audio player UI on inline audio controls is gigantic and clipped#53224

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Phinny01:eng/The-audio-player-UI-on-inline-audio-controls-is-gigantic-and-clipped
Oct 31, 2025
Merged

The audio player UI on inline audio controls is gigantic and clipped#53224
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Phinny01:eng/The-audio-player-UI-on-inline-audio-controls-is-gigantic-and-clipped

Conversation

@Phinny01
Copy link
Contributor

@Phinny01 Phinny01 commented Oct 30, 2025

3010259

The audio player UI on inline audio controls is gigantic and clipped
https://bugs.webkit.org/show_bug.cgi?id=301718
rdar://163643539

Reviewed by Jer Noble.

Add :not(.audio) selector in the macOSInlineMediaControlsStyleSheet and
macos-inline-media-controls.js to avoid changing the appearnace of the mac inline audio controls.

* Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls.prototype._setupVolumeSliderConfiguration):
(MacOSInlineMediaControls.prototype.layout):
(MacOSInlineMediaControls.prototype.handleEvent):
(MacOSInlineMediaControls.prototype.rightContainerButtons):
(MacOSInlineMediaControls):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::macOSInlineMediaControlsStyleSheet):

Canonical link: https://commits.webkit.org/302396@main

72f739b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe loading 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 loading 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Phinny01 Phinny01 self-assigned this Oct 30, 2025
@Phinny01 Phinny01 added the Media Bugs related to the HTML 5 Media elements. label Oct 30, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 31, 2025
@jernoble jernoble added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Oct 31, 2025
https://bugs.webkit.org/show_bug.cgi?id=301718
rdar://163643539

Reviewed by Jer Noble.

Add :not(.audio) selector in the macOSInlineMediaControlsStyleSheet and
macos-inline-media-controls.js to avoid changing the appearnace of the mac inline audio controls.

* Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls.prototype._setupVolumeSliderConfiguration):
(MacOSInlineMediaControls.prototype.layout):
(MacOSInlineMediaControls.prototype.handleEvent):
(MacOSInlineMediaControls.prototype.rightContainerButtons):
(MacOSInlineMediaControls):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::macOSInlineMediaControlsStyleSheet):

Canonical link: https://commits.webkit.org/302396@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/The-audio-player-UI-on-inline-audio-controls-is-gigantic-and-clipped branch from 72f739b to 3010259 Compare October 31, 2025 19:04
@webkit-commit-queue
Copy link
Collaborator

Committed 302396@main (3010259): https://commits.webkit.org/302396@main

Reviewed commits have been landed. Closing PR #53224 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3010259 into WebKit:main Oct 31, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants