Make the latest version of WebKit working on QNX #54920

fxing-qnx · 2025-12-05T14:50:54Z

`f0d351d`

Make the latest version of WebKit working on QNX
https://bugs.webkit.org/show_bug.cgi?id=303626

Reviewed by Justin Michaud.

- MemoryPressureHandlerUnix.cpp is now included in CMake for QNX
- Stack bounds for each JIT instance was not correctly set, __tls() only return thread infomation for the calling thread rather than a newly spawned thread
- currentExecutablePath() is now implemented for QNX
- stackPointer() is now implemented for QNX
- structureHeapAddressSize is now set to 128M for QNX. QNX does not allowed lazy allocation of memory, mapping 4G will ends up with allocating 4G
- Fix some headers includes
- numberOfProcessorCores() is now implemented for QNX

(computeJSCBytecodeCacheVersion()):
* Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp:
(static inline void*& stackPointerImpl()):
* Source/JavaScriptCore/runtime/MachineContext.h:
(structureHeapAddressSize):
* Source/JavaScriptCore/runtime/StructureID.h:
(WTF::numberOfProcessorCores()):
* Source/WTF/wtf/NumberOfCores.cpp:
(WTF::StackBounds::currentThreadStackBoundsInternal()):
* Source/WTF/wtf/PlatformHave.h:
* Source/WTF/wtf/StackBounds.cpp:
(WTF::currentExecutablePath()):
* Source/WTF/wtf/glib/FileSystemGlib.cpp:
(WTF::OSAllocator::commit(...)):
* Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:
* Source/WTF/wtf/PlatformGTK.cmake:

Canonical link: https://commits.webkit.org/304481@main

f8b6ae3

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WTF/wtf/StackBounds.cpp

webkit-early-warning-system · 2025-12-08T17:50:01Z

EWS run on previous version of this PR (hash d5f73c8)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WTF/wtf/glib/FileSystemGlib.cpp

Source/WTF/wtf/PlatformGTK.cmake

justinmichaud

r=me with @mcatanzaro's suggestions. It would be really cool to see a demo of this running!

webkit-early-warning-system · 2025-12-09T14:15:28Z

EWS run on previous version of this PR (hash cdeddcc)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 win
	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 api-mac-debug	~~🛠 wpe-cairo-libwebrtc~~
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	~~🧪 mac-wk1~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 vision	~~🧪 mac-wk2~~	⏳ 🧪 gtk-wk2
	⏳ 🛠 vision-sim	⏳ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-wk2-stress~~	⏳ 🛠 playstation
	⏳ 🛠 tv	⏳ 🧪 mac-intel-wk2	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	~~🛠 mac-safer-cpp~~	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2025-12-09T14:17:25Z

EWS run on previous version of this PR (hash 0f23afd)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
❌ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-commit-queue · 2025-12-15T16:09:05Z

This change contains multiple commits which are not squashed together, blocking PR #54920. Please squash the commits to land.

fxing-qnx · 2025-12-15T16:19:56Z

r=me with @mcatanzaro's suggestions. It would be really cool to see a demo of this running!

Here we go............

fxing-qnx · 2025-12-15T16:20:27Z

I am not sure if I have the permission to squash all commits

justinmichaud · 2025-12-15T16:59:56Z

You just need to squash them on your local branch

fxing-qnx · 2025-12-15T17:38:46Z

It should be good now

webkit-early-warning-system · 2025-12-15T18:06:51Z

EWS run on previous version of this PR (hash 3be29ed)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk1~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
❌ 🛠 🧪 merge	~~🧪 vision-wk2~~	~~🧪 mac-wk2-stress~~	⏳ 🛠 playstation
	✅ 🛠 tv	~~🧪 mac-intel-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-commit-queue · 2025-12-15T18:09:47Z

No reviewer information in commit message, blocking PR #54920. Details: Build #28517

webkit-early-warning-system · 2025-12-15T18:21:29Z

EWS run on current version of this PR (hash f8b6ae3)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=303626 Reviewed by Justin Michaud. - MemoryPressureHandlerUnix.cpp is now included in CMake for QNX - Stack bounds for each JIT instance was not correctly set, __tls() only return thread infomation for the calling thread rather than a newly spawned thread - currentExecutablePath() is now implemented for QNX - stackPointer() is now implemented for QNX - structureHeapAddressSize is now set to 128M for QNX. QNX does not allowed lazy allocation of memory, mapping 4G will ends up with allocating 4G - Fix some headers includes - numberOfProcessorCores() is now implemented for QNX (computeJSCBytecodeCacheVersion()): * Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp: (static inline void*& stackPointerImpl()): * Source/JavaScriptCore/runtime/MachineContext.h: (structureHeapAddressSize): * Source/JavaScriptCore/runtime/StructureID.h: (WTF::numberOfProcessorCores()): * Source/WTF/wtf/NumberOfCores.cpp: (WTF::StackBounds::currentThreadStackBoundsInternal()): * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/StackBounds.cpp: (WTF::currentExecutablePath()): * Source/WTF/wtf/glib/FileSystemGlib.cpp: (WTF::OSAllocator::commit(...)): * Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp: * Source/WTF/wtf/PlatformGTK.cmake: Canonical link: https://commits.webkit.org/304481@main

webkit-commit-queue · 2025-12-16T00:48:19Z

Committed 304481@main (f0d351d): https://commits.webkit.org/304481@main

Reviewed commits have been landed. Closing PR #54920 and removing active labels.

fxing-qnx requested review from a team as code owners December 5, 2025 14:50

Ahmad-S792 assigned fxing-qnx Dec 6, 2025

justinmichaud reviewed Dec 8, 2025

View reviewed changes

Source/WTF/wtf/StackBounds.cpp Show resolved Hide resolved

mcatanzaro reviewed Dec 8, 2025

View reviewed changes

Source/WTF/wtf/glib/FileSystemGlib.cpp Outdated Show resolved Hide resolved

mcatanzaro reviewed Dec 8, 2025

View reviewed changes

Source/WTF/wtf/PlatformGTK.cmake Outdated Show resolved Hide resolved

justinmichaud approved these changes Dec 9, 2025

View reviewed changes

fxing-qnx requested review from justinmichaud and mcatanzaro December 15, 2025 16:05

justinmichaud added the merge-queue Applied to send a pull request to merge-queue label Dec 15, 2025

webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Dec 15, 2025

fxing-qnx force-pushed the master branch from 0f23afd to 3be29ed Compare December 15, 2025 17:36

justinmichaud added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 15, 2025

webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Dec 15, 2025

fxing-qnx force-pushed the master branch from 3be29ed to f8b6ae3 Compare December 15, 2025 18:21

justinmichaud removed the merging-blocked Applied to prevent a change from being merged label Dec 16, 2025

justinmichaud approved these changes Dec 16, 2025

View reviewed changes

justinmichaud added the merge-queue Applied to send a pull request to merge-queue label Dec 16, 2025

webkit-commit-queue force-pushed the master branch from f8b6ae3 to f0d351d Compare December 16, 2025 00:48

webkit-commit-queue merged commit f0d351d into WebKit:main Dec 16, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 16, 2025

Make the latest version of WebKit working on QNX #54920

Make the latest version of WebKit working on QNX #54920

Uh oh!

Conversation

fxing-qnx commented Dec 5, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

f0d351d

Uh oh!

Uh oh!

webkit-early-warning-system commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinmichaud left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Dec 15, 2025

Uh oh!

fxing-qnx commented Dec 15, 2025

Uh oh!

fxing-qnx commented Dec 15, 2025

Uh oh!

justinmichaud commented Dec 15, 2025

Uh oh!

fxing-qnx commented Dec 15, 2025

Uh oh!

webkit-early-warning-system commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Dec 15, 2025

Uh oh!

webkit-early-warning-system commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fxing-qnx commented Dec 5, 2025 •

edited by webkit-early-warning-system

Loading

`f0d351d`

webkit-early-warning-system commented Dec 8, 2025 •

edited

Loading

webkit-early-warning-system commented Dec 9, 2025 •

edited

Loading

webkit-early-warning-system commented Dec 9, 2025 •

edited

Loading

webkit-early-warning-system commented Dec 15, 2025 •

edited

Loading

webkit-early-warning-system commented Dec 15, 2025 •

edited

Loading