Skip to content

REGRESSION(303017@main): Broke running --site-isolation with --iOS-simulator locally #55118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robert-jenner wants to merge 1 commit into from
Closed

REGRESSION(303017@main): Broke running --site-isolation with --iOS-simulator locally #55118

robert-jenner wants to merge 1 commit into from

Conversation

@robert-jenner
Copy link
Contributor

@robert-jenner robert-jenner commented Dec 9, 2025 •
edited by webkit-early-warning-system
Loading

919c4b0

REGRESSION(303017@main): Broke running --site-isolation with --iOS-simulator locally
rdar://166160572
https://bugs.webkit.org/show_bug.cgi?id=303864

Reviewed by NOBODY (OOPS!).

This modifies running --site-isolation with --ios-simulator locally so that it works, and doesn't hit the _smc attribution error.

* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):

919c4b0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 webkitpy   🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
❌ 🛠 🧪 merge   🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@robert-jenner robert-jenner self-assigned this Dec 9, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 9, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 34d2e5c)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ⏳ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
⏳ 🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 vision   🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 vision-sim ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress ⏳ 🛠 playstation
⏳ 🛠 tv ⏳ 🧪 mac-intel-wk2
⏳ 🛠 tv-sim ⏳ 🛠 mac-safer-cpp
⏳ 🛠 watch
⏳ 🛠 watch-sim

@robert-jenner robert-jenner force-pushed the eng/REGRESSION-303017-main-Broke-running-site-isolation-with-iOS-simulator-locally branch from 34d2e5c to fa5c263 Compare December 9, 2025 19:31
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 9, 2025 •
edited
Loading

EWS run on previous version of this PR (hash fa5c263)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ⏳ 🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ⏳ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
⏳ 🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
⏳ 🛠 vision   🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 vision-sim ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🧪 mac-intel-wk2
⏳ 🛠 tv-sim ⏳ 🛠 mac-safer-cpp
⏳ 🛠 watch
⏳ 🛠 watch-sim

@robert-jenner robert-jenner force-pushed the eng/REGRESSION-303017-main-Broke-running-site-isolation-with-iOS-simulator-locally branch from fa5c263 to c7f1e87 Compare December 9, 2025 19:36
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 9, 2025 •
edited
Loading

EWS run on previous version of this PR (hash c7f1e87)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
⏳ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
❌ 🛠 🧪 merge   🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv   🧪 mac-intel-wk2
⏳ 🛠 tv-sim
⏳ 🛠 watch
✅ 🛠 watch-sim

@robert-jenner robert-jenner added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Dec 9, 2025
@robert-jenner robert-jenner force-pushed the eng/REGRESSION-303017-main-Broke-running-site-isolation-with-iOS-simulator-locally branch from c7f1e87 to dd03c88 Compare December 9, 2025 20:55
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 9, 2025 •
edited
Loading

EWS run on previous version of this PR (hash dd03c88)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
⏳ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
❌ 🛠 🧪 merge ⏳ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
❌ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🧪 mac-intel-wk2
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

@robert-jenner robert-jenner added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Dec 9, 2025
@robert-jenner
REGRESSION(303017@main): Broke running --site-isolation with --iOS-si…
919c4b0 
…mulator locally

rdar://166160572
https://bugs.webkit.org/show_bug.cgi?id=303864

Reviewed by NOBODY (OOPS!).

This modifies running --site-isolation with --ios-simulator locally so that it works, and doesn't hit the _smc attribution error.

* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
@robert-jenner robert-jenner removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 9, 2025
@robert-jenner robert-jenner force-pushed the eng/REGRESSION-303017-main-Broke-running-site-isolation-with-iOS-simulator-locally branch from dd03c88 to 919c4b0 Compare December 9, 2025 22:18
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 9, 2025 •
edited
Loading

EWS run on current version of this PR (hash 919c4b0)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 webkitpy   🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
❌ 🛠 🧪 merge   🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@robert-jenner robert-jenner added the merge-queue Applied to send a pull request to merge-queue label Dec 9, 2025
@robert-jenner robert-jenner deleted the eng/REGRESSION-303017-main-Broke-running-site-isolation-with-iOS-simulator-locally branch December 10, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szewai szewai szewai approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@gsnedders gsnedders Awaiting requested review from gsnedders gsnedders is a code owner

Assignees

@robert-jenner robert-jenner

Labels

merge-queue Applied to send a pull request to merge-queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robert-jenner @webkit-early-warning-system @szewai