Skip to content

Conversation

@carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Dec 18, 2025

42c5ccc

[GTK][WPE] Fix an assert when threaded compositor is invalidated right before renderLayerTree is called
https://bugs.webkit.org/show_bug.cgi?id=304395

Reviewed by Nikolas Zimmermann.

The main thread invalidates the threaded compositor, which switches to
Idle state, right before renderLayerTree is called in the compositing
thread that hits the assert checking state should be Scheduled. We
should return early from renderLayerTree if the timer has already been
stopped.

Canonical link: https://commits.webkit.org/304667@main

c74d426

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
🛠 watch
🛠 watch-sim

@carlosgcampos carlosgcampos self-assigned this Dec 18, 2025
@carlosgcampos carlosgcampos added the WebKitGTK Bugs related to the Gtk API layer. label Dec 18, 2025
@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 18, 2025
…t before renderLayerTree is called

https://bugs.webkit.org/show_bug.cgi?id=304395

Reviewed by Nikolas Zimmermann.

The main thread invalidates the threaded compositor, which switches to
Idle state, right before renderLayerTree is called in the compositing
thread that hits the assert checking state should be Scheduled. We
should return early from renderLayerTree if the timer has already been
stopped.

Canonical link: https://commits.webkit.org/304667@main
@webkit-commit-queue webkit-commit-queue force-pushed the wk-compositor-invalidate-assert branch from c74d426 to 42c5ccc Compare December 18, 2025 11:01
@webkit-commit-queue
Copy link
Collaborator

Committed 304667@main (42c5ccc): https://commits.webkit.org/304667@main

Reviewed commits have been landed. Closing PR #55617 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 42c5ccc into WebKit:main Dec 18, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 18, 2025
@carlosgcampos carlosgcampos deleted the wk-compositor-invalidate-assert branch December 18, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants