Skip to content

Update Safer CPP expectation files for AccessibilitySpinButton.cpp #55635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Dec 18, 2025
Merged

Update Safer CPP expectation files for AccessibilitySpinButton.cpp #55635

webkit-commit-queue merged 1 commit into from
Dec 18, 2025

Conversation

@jelee53
Copy link
Contributor

@jelee53 jelee53 commented Dec 18, 2025 •
edited by webkit-early-warning-system
Loading

cb713ad

Update Safer CPP expectation files for AccessibilitySpinButton.cpp
https://bugs.webkit.org/show_bug.cgi?id=304417
rdar://166801024

Unreviewed

Companion bug to "Adopt Safer CPP in AccessibilitySpinButton.cpp", #55600

No new tests needed.

* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/304690@main

ee73788

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ❌ 🛠 wpe-cairo-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ❌ 🛠 gtk
✅ 🛠 vision   🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
  🛠 🧪 merge   🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🧪 mac-intel-wk2
✅ 🛠 tv-sim   🛠 mac-safer-cpp
✅ 🛠 watch
  🛠 watch-sim

@jelee53 jelee53 self-assigned this Dec 18, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 18, 2025 •
edited
Loading

EWS run on previous version of this PR (hash bcb2bd1)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv   🧪 mac-intel-wk2
✅ 🛠 tv-sim   🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@jelee53 jelee53 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Dec 18, 2025
@jelee53 jelee53 requested a review from annevk December 18, 2025 18:02
rniwa
rniwa approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need a formal review these.

@jelee53 jelee53 force-pushed the eng/Update-Safer-CPP-expectation-files-for-AccessibilitySpinButton-cpp branch from bcb2bd1 to ee73788 Compare December 18, 2025 18:11
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 18, 2025 •
edited
Loading

EWS run on current version of this PR (hash ee73788)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ❌ 🛠 wpe-cairo-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ❌ 🛠 gtk
✅ 🛠 vision   🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
  🛠 🧪 merge   🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🧪 mac-intel-wk2
✅ 🛠 tv-sim   🛠 mac-safer-cpp
✅ 🛠 watch
  🛠 watch-sim

@jelee53 jelee53 added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Dec 18, 2025
@jelee53
Update Safer CPP expectation files for AccessibilitySpinButton.cpp
cb713ad 
https://bugs.webkit.org/show_bug.cgi?id=304417
rdar://166801024

Unreviewed

Companion bug to "Adopt Safer CPP in AccessibilitySpinButton.cpp", WebKit#55600

No new tests needed.

* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/304690@main
@jelee53 jelee53 removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 18, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Update-Safer-CPP-expectation-files-for-AccessibilitySpinButton-cpp branch from ee73788 to cb713ad Compare December 18, 2025 18:14
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Dec 18, 2025

Committed 304690@main (cb713ad): https://commits.webkit.org/304690@main

Reviewed commits have been landed. Closing PR #55635 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cb713ad into WebKit:main Dec 18, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rniwa rniwa rniwa approved these changes

@annevk annevk Awaiting requested review from annevk

Assignees

@jelee53 jelee53

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jelee53 @webkit-early-warning-system @webkit-commit-queue @rniwa