-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[AutoFill Debugging] Add form elements and more text form control DOM attributes #55716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on previous version of this PR (hash c253608) Details |
pxlcoder
approved these changes
Dec 19, 2025
Collaborator
|
EWS run on current version of this PR (hash 9eac033) Details |
Member
Author
|
Thanks for the review! |
… attributes https://bugs.webkit.org/show_bug.cgi?id=304508 rdar://166750217 Reviewed by Aditya Keerthi. Add several new DOM attributes to the text extraction output on text fields: - `pattern` - `minlength` - `maxlength` - `name` ...and also introduce a new container type, `form`, which represents a `form` element with attributes: - `name` - `autocomplete` * LayoutTests/fast/text-extraction/debug-text-extraction-form-controls-expected.txt: * LayoutTests/fast/text-extraction/debug-text-extraction-form-controls.html: Augment an existing test to include a new `form` that contains a few text fields. * Source/WebCore/page/text-extraction/TextExtraction.cpp: (WebCore::TextExtraction::extractItemData): * Source/WebCore/page/text-extraction/TextExtractionTypes.h: * Source/WebKit/Shared/TextExtractionToStringConversion.cpp: (WebKit::addPartsForItem): (WebKit::addTextRepresentationRecursive): Drive-by fix: address an issue where a single text child node can be incorrectly flagged as "redundant with the HREF" in the case where the client has opted out of including URLs. I spotted this while looking through the augmented layout test's HTML text representation above, since the anchor tags were just getting surfaced as `<a>` with no text or href. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.swift: * Source/WebKit/UIProcess/API/Cocoa/_WKTextExtractionInternal.h: * Source/WebKit/UIProcess/Cocoa/TextExtraction/WKTextExtractionUtilities.mm: (WebKit::createItemWithChildren): * Tools/WebKitTestRunner/cocoa/WKTextExtractionTestingHelpers.mm: (WTR::buildDescriptionIgnoringChildren): Canonical link: https://commits.webkit.org/304785@main
9eac033 to
f17dbea
Compare
Collaborator
|
Committed 304785@main (f17dbea): https://commits.webkit.org/304785@main Reviewed commits have been landed. Closing PR #55716 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
f17dbea
9eac033
🛠 win🧪 win-tests