-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[LOL] Add support for bitwise bytecodes #55727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
kmiller68:eng/LOL-Add-support-for-bitwise-bytecodes
Dec 19, 2025
Merged
[LOL] Add support for bitwise bytecodes #55727
webkit-commit-queue
merged 1 commit into
WebKit:main
from
kmiller68:eng/LOL-Add-support-for-bitwise-bytecodes
Dec 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
EWS run on previous version of this PR (hash 7d23d49) Details
|
7d23d49 to
5f33114
Compare
Collaborator
|
EWS run on current version of this PR (hash 5f33114) Details |
MenloDorian
approved these changes
Dec 19, 2025
MenloDorian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
https://bugs.webkit.org/show_bug.cgi?id=304516 rdar://problem/166899891 Reviewed by Mark Lam. Add support for bit_not/or/xor/and opcodes. It's a pretty trivial migration, with the only notable change being to use a two operand not for bitnot so it doesn't clobber the use. It's worth noting that these use CommonSlowPaths slow paths so those work out of the box, albeit inefficiently. No new behavior, covered by existing tests. Canonical link: https://commits.webkit.org/304786@main
5f33114 to
2ddabc5
Compare
Collaborator
|
Committed 304786@main (2ddabc5): https://commits.webkit.org/304786@main Reviewed commits have been landed. Closing PR #55727 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2ddabc5
5f33114
🛠 win🧪 win-tests🧪 api-mac-debug