Skip to content

Conversation

@kmiller68
Copy link
Contributor

@kmiller68 kmiller68 commented Dec 19, 2025

@kmiller68 kmiller68 requested a review from a team as a code owner December 19, 2025 21:12
@kmiller68 kmiller68 self-assigned this Dec 19, 2025
@kmiller68 kmiller68 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Dec 19, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 19, 2025
@kmiller68 kmiller68 removed the merging-blocked Applied to prevent a change from being merged label Dec 19, 2025
@kmiller68 kmiller68 force-pushed the eng/LOL-Add-support-for-bitwise-bytecodes branch from 7d23d49 to 5f33114 Compare December 19, 2025 21:25
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@kmiller68 kmiller68 added the merge-queue Applied to send a pull request to merge-queue label Dec 19, 2025
https://bugs.webkit.org/show_bug.cgi?id=304516
rdar://problem/166899891

Reviewed by Mark Lam.

Add support for bit_not/or/xor/and opcodes. It's a pretty trivial
migration, with the only notable change being to use a two operand
not for bitnot so it doesn't clobber the use.

It's worth noting that these use CommonSlowPaths slow paths so those
work out of the box, albeit inefficiently.

No new behavior, covered by existing tests.

Canonical link: https://commits.webkit.org/304786@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/LOL-Add-support-for-bitwise-bytecodes branch from 5f33114 to 2ddabc5 Compare December 19, 2025 23:41
@webkit-commit-queue
Copy link
Collaborator

Committed 304786@main (2ddabc5): https://commits.webkit.org/304786@main

Reviewed commits have been landed. Closing PR #55727 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2ddabc5 into WebKit:main Dec 19, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants