Skip to content

Conversation

@philn
Copy link
Member

@philn philn commented Dec 23, 2025

8e56989

[WebRTC] Remove obsolete emulateRTCPeerConnectionPlatformEvent
https://bugs.webkit.org/show_bug.cgi?id=304638

Reviewed by Adrian Perez de Castro.

That was needed in OpenWebRTC times and was left un-implemented when libwebrtc was added.

* LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event.html:
* LayoutTests/fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event.html:
* LayoutTests/fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::emulatePlatformEvent): Deleted.
* Source/WebCore/Modules/mediastream/RTCPeerConnection.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::emulateRTCPeerConnectionPlatformEvent): Deleted.
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/304896@main

a82af4f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ❌ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Dec 23, 2025
@philn philn added the WebRTC For bugs in WebRTC label Dec 23, 2025
@philn philn requested review from jyavenard and youennf December 23, 2025 09:40
Copy link
Contributor

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code deletion, yay!

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 23, 2025
@philn philn added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 23, 2025
https://bugs.webkit.org/show_bug.cgi?id=304638

Reviewed by Adrian Perez de Castro.

That was needed in OpenWebRTC times and was left un-implemented when libwebrtc was added.

* LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event.html:
* LayoutTests/fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event.html:
* LayoutTests/fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::emulatePlatformEvent): Deleted.
* Source/WebCore/Modules/mediastream/RTCPeerConnection.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::emulateRTCPeerConnectionPlatformEvent): Deleted.
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/304896@main
@webkit-commit-queue
Copy link
Collaborator

Committed 304896@main (8e56989): https://commits.webkit.org/304896@main

Reviewed commits have been landed. Closing PR #55826 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8e56989 into WebKit:main Dec 23, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 23, 2025
@philn philn deleted the eng/304638 branch December 23, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebRTC For bugs in WebRTC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants