[CI Filters] Implement FEGaussianBlur in Core Image, and fix some geometry issues #56009

smfr · 2026-01-02T18:40:20Z

`bb11508`

[CI Filters] Implement FEGaussianBlur in Core Image, and fix some geometry issues
https://bugs.webkit.org/show_bug.cgi?id=304854
rdar://167443665

Reviewed by Mike Wyrzykowski.

Add FEGaussianBlurCoreImageApplier, which uses a `CIGaussianBlurXY` filter so we can control
X and Y radii independently.

Testing this revealed an issue where the geometry was wrong for SVG reference filters used
in CSS. When a CSS filter chain contains both CSS and SVG filters, the entire chain is rendered
using Core Image if possible. This means that every primitive needs to use the same reference
geometry, since Core Image works in flipped coordinates, so the rect relative to which flipping
happens needs to be consistent.

To fix this, introduce the concept of an "enclosing filter region", which is the union of
the filterRegions of all the filters in the chain. This is computed by `CSSFilterRenderer`
just before applying. Each primitive can then use
`filter.flippedRectRelativeToAbsoluteEnclosingFilterRegion(result.absoluteImageRect())`
to compute the correct extent rect.

Add `BEGIN_BLOCK_OBJC_EXCEPTIONS`/`END_BLOCK_OBJC_EXCEPTIONS` around all the CI code.

* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/coreimage/FEBlendCoreImageApplier.mm:
(WebCore::FEBlendCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm:
(WebCore::FEColorMatrixCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm:
* Source/WebCore/platform/graphics/coreimage/FECompositeCoreImageApplier.mm:
(WebCore::FECompositeCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/FEFloodCoreImageApplier.mm:
(WebCore::FEFloodCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/FEGaussianBlurCoreImageApplier.h:
* Source/WebCore/platform/graphics/coreimage/FEGaussianBlurCoreImageApplier.mm:
(WebCore::FEGaussianBlurCoreImageApplier::FEGaussianBlurCoreImageApplier):
(WebCore::FEGaussianBlurCoreImageApplier::supportsCoreImageRendering):
(WebCore::FEGaussianBlurCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/FEMorphologyCoreImageApplier.mm:
(WebCore::FEMorphologyCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/FilterImageCoreImage.mm:
(WebCore::FilterImage::filterResultImageBuffer):
* Source/WebCore/platform/graphics/coreimage/SourceAlphaCoreImageApplier.mm:
(WebCore::SourceAlphaCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm:
(WebCore::SourceGraphicCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::supportedFilterRenderingModes const):
(WebCore::FEGaussianBlur::createAcceleratedApplier const):
* Source/WebCore/platform/graphics/filters/Filter.cpp:
(WebCore::Filter::Filter):
(WebCore::Filter::absoluteEnclosingFilterRegion const):
(WebCore::Filter::flippedRectRelativeToAbsoluteEnclosingFilterRegion const):
(WebCore::Filter::filterResultBuffer const):
* Source/WebCore/platform/graphics/filters/Filter.h:
(WebCore::Filter::enclosingFilterRegion const):
(WebCore::Filter::setEnclosingFilterRegion):
* Source/WebCore/platform/network/mac/WebCoreURLResponse.mm: Unified sources fix.
* Source/WebCore/rendering/CSSFilterRenderer.cpp:
(WebCore::CSSFilterRenderer::computeEnclosingFilterRegion):
* Source/WebCore/rendering/CSSFilterRenderer.h:

Canonical link: https://commits.webkit.org/305054@main

653d01d

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-01-02T18:40:25Z

EWS run on previous version of this PR (hash e41a15c)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~		✅ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	~~🛠 wpe-cairo-libwebrtc~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🛠 gtk~~
	✅ 🛠 vision	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-wk2-stress~~	~~🛠 playstation~~
	✅ 🛠 tv	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv-sim	❌ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-01-02T18:46:58Z

EWS run on previous version of this PR (hash be5879e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	❌ 🛠 wpe-cairo-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	❌ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv-sim	❌ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim

mwyrzykowski · 2026-01-02T19:29:31Z

Source/WebCore/platform/graphics/coreimage/FEGaussianBlurCoreImageApplier.mm

+    // FIXME: Support edge modes.
+    auto absoluteStdDeviation = filter.scaledByFilterScale(FloatSize(m_effect->stdDeviationX(), m_effect->stdDeviationY()));
+
+    auto ciFilter = [CIFilter filterWithName:@"CIGaussianBlurXY"];


should you use RetainPtr here since filterWithName says:

Creates a CIFilter object for a specific kind of filter.

so presumably an auto-released object is returned?

This should be a RetainPtr

webkit-ews-buildbot · 2026-01-02T19:49:57Z

Safer C++ Build #72966 (`e41a15c`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-ews-buildbot · 2026-01-02T19:58:57Z

Safer C++ Build #72968 (`be5879e`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2026-01-02T20:11:31Z

EWS run on previous version of this PR (hash 726fb60)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~		✅ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	~~🛠 wpe-cairo-libwebrtc~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	~~🧪 vision-wk2~~	~~🧪 mac-wk2-stress~~	✅ 🛠 playstation
	✅ 🛠 tv	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv-sim	~~🛠 mac-safer-cpp~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-01-02T20:15:31Z

EWS run on current version of this PR (hash 653d01d)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim

…metry issues https://bugs.webkit.org/show_bug.cgi?id=304854 rdar://167443665 Reviewed by Mike Wyrzykowski. Add FEGaussianBlurCoreImageApplier, which uses a `CIGaussianBlurXY` filter so we can control X and Y radii independently. Testing this revealed an issue where the geometry was wrong for SVG reference filters used in CSS. When a CSS filter chain contains both CSS and SVG filters, the entire chain is rendered using Core Image if possible. This means that every primitive needs to use the same reference geometry, since Core Image works in flipped coordinates, so the rect relative to which flipping happens needs to be consistent. To fix this, introduce the concept of an "enclosing filter region", which is the union of the filterRegions of all the filters in the chain. This is computed by `CSSFilterRenderer` just before applying. Each primitive can then use `filter.flippedRectRelativeToAbsoluteEnclosingFilterRegion(result.absoluteImageRect())` to compute the correct extent rect. Add `BEGIN_BLOCK_OBJC_EXCEPTIONS`/`END_BLOCK_OBJC_EXCEPTIONS` around all the CI code. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/coreimage/FEBlendCoreImageApplier.mm: (WebCore::FEBlendCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm: (WebCore::FEColorMatrixCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm: * Source/WebCore/platform/graphics/coreimage/FECompositeCoreImageApplier.mm: (WebCore::FECompositeCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/FEFloodCoreImageApplier.mm: (WebCore::FEFloodCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/FEGaussianBlurCoreImageApplier.h: * Source/WebCore/platform/graphics/coreimage/FEGaussianBlurCoreImageApplier.mm: (WebCore::FEGaussianBlurCoreImageApplier::FEGaussianBlurCoreImageApplier): (WebCore::FEGaussianBlurCoreImageApplier::supportsCoreImageRendering): (WebCore::FEGaussianBlurCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/FEMorphologyCoreImageApplier.mm: (WebCore::FEMorphologyCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/FilterImageCoreImage.mm: (WebCore::FilterImage::filterResultImageBuffer): * Source/WebCore/platform/graphics/coreimage/SourceAlphaCoreImageApplier.mm: (WebCore::SourceAlphaCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm: (WebCore::SourceGraphicCoreImageApplier::apply const): * Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::supportedFilterRenderingModes const): (WebCore::FEGaussianBlur::createAcceleratedApplier const): * Source/WebCore/platform/graphics/filters/Filter.cpp: (WebCore::Filter::Filter): (WebCore::Filter::absoluteEnclosingFilterRegion const): (WebCore::Filter::flippedRectRelativeToAbsoluteEnclosingFilterRegion const): (WebCore::Filter::filterResultBuffer const): * Source/WebCore/platform/graphics/filters/Filter.h: (WebCore::Filter::enclosingFilterRegion const): (WebCore::Filter::setEnclosingFilterRegion): * Source/WebCore/platform/network/mac/WebCoreURLResponse.mm: Unified sources fix. * Source/WebCore/rendering/CSSFilterRenderer.cpp: (WebCore::CSSFilterRenderer::computeEnclosingFilterRegion): * Source/WebCore/rendering/CSSFilterRenderer.h: Canonical link: https://commits.webkit.org/305054@main

webkit-commit-queue · 2026-01-02T21:59:09Z

Committed 305054@main (bb11508): https://commits.webkit.org/305054@main

Reviewed commits have been landed. Closing PR #56009 and removing active labels.

smfr self-assigned this Jan 2, 2026

smfr added the SVG For bugs in the SVG implementation. label Jan 2, 2026

smfr force-pushed the eng/CI-Filters-Implement-FEGaussianBlur-in-Core-Image-and-fix-some-geometry-issues branch from e41a15c to be5879e Compare January 2, 2026 18:46

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 2, 2026

mwyrzykowski self-requested a review January 2, 2026 19:09

mwyrzykowski reviewed Jan 2, 2026

View reviewed changes

mwyrzykowski approved these changes Jan 2, 2026

View reviewed changes

smfr removed the merging-blocked Applied to prevent a change from being merged label Jan 2, 2026

smfr force-pushed the eng/CI-Filters-Implement-FEGaussianBlur-in-Core-Image-and-fix-some-geometry-issues branch from be5879e to 726fb60 Compare January 2, 2026 20:11

smfr force-pushed the eng/CI-Filters-Implement-FEGaussianBlur-in-Core-Image-and-fix-some-geometry-issues branch from 726fb60 to 653d01d Compare January 2, 2026 20:15

smfr added the merge-queue Applied to send a pull request to merge-queue label Jan 2, 2026

webkit-commit-queue force-pushed the eng/CI-Filters-Implement-FEGaussianBlur-in-Core-Image-and-fix-some-geometry-issues branch from 653d01d to bb11508 Compare January 2, 2026 21:59

webkit-commit-queue merged commit bb11508 into WebKit:main Jan 2, 2026

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CI Filters] Implement FEGaussianBlur in Core Image, and fix some geometry issues #56009

[CI Filters] Implement FEGaussianBlur in Core Image, and fix some geometry issues #56009

smfr commented Jan 2, 2026 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading

Uh oh!

mwyrzykowski Jan 2, 2026

Uh oh!

smfr Jan 2, 2026

Uh oh!

webkit-ews-buildbot commented Jan 2, 2026

Uh oh!

webkit-ews-buildbot commented Jan 2, 2026

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading

Uh oh!

webkit-commit-queue commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[CI Filters] Implement FEGaussianBlur in Core Image, and fix some geometry issues #56009

[CI Filters] Implement FEGaussianBlur in Core Image, and fix some geometry issues #56009

Conversation

smfr commented Jan 2, 2026 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

bb11508

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwyrzykowski Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

smfr Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

webkit-ews-buildbot commented Jan 2, 2026

Safer C++ Build #72966 (e41a15c)

Uh oh!

webkit-ews-buildbot commented Jan 2, 2026

Safer C++ Build #72968 (be5879e)

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

smfr commented Jan 2, 2026 •

edited by webkit-early-warning-system

Loading

`bb11508`

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading

Safer C++ Build #72966 (`e41a15c`)

Safer C++ Build #72968 (`be5879e`)

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading

webkit-early-warning-system commented Jan 2, 2026 •

edited

Loading