Skip to content

Remove unsafe member variable in TileCoverageMap #56036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Jan 3, 2026
Merged

Remove unsafe member variable in TileCoverageMap #56036

webkit-commit-queue merged 1 commit into from
Jan 3, 2026
+19 −22

Conversation

@annevk
Copy link
Contributor

@annevk annevk commented Jan 3, 2026 •
edited by webkit-early-warning-system
Loading

70794c6

Remove unsafe member variable in TileCoverageMap
https://bugs.webkit.org/show_bug.cgi?id=304882

Reviewed by Alex Christensen.

Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines

Canonical link: https://commits.webkit.org/305072@main

95e7e9e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jan 3, 2026
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@annevk annevk added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 3, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 3, 2026
@annevk annevk marked this pull request as draft January 3, 2026 09:31
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jan 3, 2026
@annevk annevk force-pushed the eng/Remove-unsafe-member-variable-in-TileCoverageMap branch from e8f9fab to e38fe7a Compare January 3, 2026 10:09
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 3, 2026 •
edited
Loading

EWS run on previous version of this PR (hash e38fe7a)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ✅ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
  🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv   🧪 mac-intel-wk2
✅ 🛠 tv-sim   🛠 mac-safer-cpp
  🛠 watch
✅ 🛠 watch-sim

@annevk annevk force-pushed the eng/Remove-unsafe-member-variable-in-TileCoverageMap branch from e38fe7a to 95e7e9e Compare January 3, 2026 10:25
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 3, 2026 •
edited
Loading

EWS run on current version of this PR (hash 95e7e9e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk marked this pull request as ready for review January 3, 2026 10:26
@annevk annevk added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 3, 2026
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-unsafe-member-variable-in-TileCoverageMap branch from 95e7e9e to 70794c6 Compare January 3, 2026 21:12
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 3, 2026

Committed 305072@main (70794c6): https://commits.webkit.org/305072@main

Reviewed commits have been landed. Closing PR #56036 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 70794c6 into WebKit:main Jan 3, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 3, 2026
@annevk annevk deleted the eng/Remove-unsafe-member-variable-in-TileCoverageMap branch January 3, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

Assignees

@annevk annevk

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@annevk @webkit-early-warning-system @webkit-commit-queue @achristensen07 @webkit-ews-buildbot