AX: Refactor six ancestor-finding methods in AXCoreObject from pure virtual, template-based implementations to non-virtual inline member functions.#56121
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jan 6, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 0a1e789) Details
|
twilco
approved these changes
Jan 6, 2026
0a1e789 to
e8e513c
Compare
Collaborator
|
EWS run on current version of this PR (hash e8e513c) Details |
…irtual, template-based implementations to non-virtual inline member functions. https://bugs.webkit.org/show_bug.cgi?id=304967 <rdar://problem/167591275> Reviewed by Tyler Wilcock. No change in functionality. This patch refactors six ancestor-finding methods in AXCoreObject from pure virtual, template-based implementations to non-virtual inline member functions. The refactoring improves const-correctness, simplifies the inheritance hierarchy, and eliminates virtual dispatch overhead. * Source/WebCore/accessibility/AXCoreObject.h: (WebCore::AXCoreObject::editableAncestor const): (WebCore::AXCoreObject::highestEditableAncestor const): (WebCore::AXCoreObject::focusableAncestor const): (WebCore::AXCoreObject::clickableSelfOrAncestor const): (WebCore::AXCoreObject::liveRegionAncestor const): (WebCore::AXCoreObject::exposedTableAncestor const): (WebCore::Accessibility::focusableAncestor): Deleted. (WebCore::Accessibility::editableAncestor): Deleted. (WebCore::Accessibility::highestEditableAncestor): Deleted. (WebCore::Accessibility::liveRegionAncestor): Deleted. (WebCore::Accessibility::exposedTableAncestor): Deleted. * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityHeaderElements]): (-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]): (-[WebAccessibilityObjectWrapper accessibilityRowCount]): (-[WebAccessibilityObjectWrapper accessibilityColumnCount]): (-[WebAccessibilityObjectWrapper accessibilityARIARowCount]): (-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]): (-[WebAccessibilityObjectWrapper tableParent]): Deleted. * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: In both derived classes, removed simple forwarding functions to the template implementations. With the base class now providing concrete implementations, these overrides are no longer needed. Canonical link: https://commits.webkit.org/305170@main
e8e513c to
a1f5e0b
Compare
Collaborator
|
Committed 305170@main (a1f5e0b): https://commits.webkit.org/305170@main Reviewed commits have been landed. Closing PR #56121 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a1f5e0b
e8e513c
🧪 win-tests