Test changes for relaxed name validation#56248
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 3, 2026
Merged
Test changes for relaxed name validation#56248webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 3e08df3) Details |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3e08df3 to
281f985
Compare
Collaborator
|
EWS run on previous version of this PR (hash 281f985) Details |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
annevk
reviewed
Jan 8, 2026
Contributor
annevk
left a comment
There was a problem hiding this comment.
This looks good to me modulo bots, but I suspect the bots will complain about a few things here.
LayoutTests/fast/dom/DOMImplementation/createDocumentType-err-expected.txt
Outdated
Show resolved
Hide resolved
281f985 to
7885ba1
Compare
Collaborator
|
EWS run on previous version of this PR (hash 7885ba1) Details |
annevk
reviewed
Jan 11, 2026
LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt
Outdated
Show resolved
Hide resolved
7885ba1 to
14a3191
Compare
Collaborator
|
EWS run on previous version of this PR (hash 14a3191) Details |
14a3191 to
5511f82
Compare
Collaborator
|
EWS run on current version of this PR (hash 5511f82) Details |
Member
Author
|
@annevk all green here now |
5511f82 to
087cc79
Compare
https://bugs.webkit.org/show_bug.cgi?id=241419 Reviewed by Anne van Kesteren. Update WPT tests and expected results for relaxed name validation. Remove redundant WebKit-specific tests that are now covered by the WPT name-validation.html test. Tests removed (redundant with WPT): - LayoutTests/dom/html/level1/core/hc_*invalidcharacterexception* - LayoutTests/dom/html/level2/core/createDocumentType04* - LayoutTests/dom/xhtml/level1/core/hc_*invalidcharacterexception* - LayoutTests/dom/xhtml/level2/core/createDocumentType04* - LayoutTests/dom/xhtml/level3/core/documentsetstricterrorchecking01* - LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err* - LayoutTests/fast/dom/DOMImplementation/createDocumentType-err* - LayoutTests/fast/dom/Document/createAttributeNS-namespace-err* - LayoutTests/fast/dom/Document/createElement-invalid-names* - LayoutTests/fast/dom/Document/createElementNS-namespace-err* - LayoutTests/fast/dom/Element/setAttributeNS-namespace-err* - LayoutTests/fast/dom/qualified-name-validation* WPT tests added: - LayoutTests/imported/w3c/web-platform-tests/dom/nodes/name-validation.html * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateattribute-expected.txt: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateattribute.html: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateattribute.js: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateattribute1-expected.txt: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateattribute1.html: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateattribute1.js: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement-expected.txt: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement.html: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement.js: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement1-expected.txt: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement1.html: Removed. * LayoutTests/dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement1.js: Removed. * LayoutTests/dom/html/level1/core/hc_elementinvalidcharacterexception-expected.txt: Removed. * LayoutTests/dom/html/level1/core/hc_elementinvalidcharacterexception.html: Removed. * LayoutTests/dom/html/level1/core/hc_elementinvalidcharacterexception.js: Removed. * LayoutTests/dom/html/level1/core/hc_elementinvalidcharacterexception1-expected.txt: Removed. * LayoutTests/dom/html/level1/core/hc_elementinvalidcharacterexception1.html: Removed. * LayoutTests/dom/html/level1/core/hc_elementinvalidcharacterexception1.js: Removed. * LayoutTests/dom/html/level2/core/createDocumentType04-expected.txt: Removed. * LayoutTests/dom/html/level2/core/createDocumentType04.html: Removed. * LayoutTests/dom/html/level2/core/createDocumentType04.js: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateattribute-expected.txt: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateattribute.js: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateattribute.xhtml: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateattribute1-expected.txt: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateattribute1.js: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateattribute1.xhtml: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement-expected.txt: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement.js: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement.xhtml: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement1-expected.txt: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement1.js: Removed. * LayoutTests/dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement1.xhtml: Removed. * LayoutTests/dom/xhtml/level1/core/hc_elementinvalidcharacterexception-expected.txt: Removed. * LayoutTests/dom/xhtml/level1/core/hc_elementinvalidcharacterexception.js: Removed. * LayoutTests/dom/xhtml/level1/core/hc_elementinvalidcharacterexception.xhtml: Removed. * LayoutTests/dom/xhtml/level1/core/hc_elementinvalidcharacterexception1-expected.txt: Removed. * LayoutTests/dom/xhtml/level1/core/hc_elementinvalidcharacterexception1.js: Removed. * LayoutTests/dom/xhtml/level1/core/hc_elementinvalidcharacterexception1.xhtml: Removed. * LayoutTests/dom/xhtml/level2/core/createDocumentType04-expected.txt: Removed. * LayoutTests/dom/xhtml/level2/core/createDocumentType04.js: Removed. * LayoutTests/dom/xhtml/level2/core/createDocumentType04.xhtml: Removed. * LayoutTests/dom/xhtml/level3/core/documentsetstricterrorchecking01-expected.txt: Removed. * LayoutTests/dom/xhtml/level3/core/documentsetstricterrorchecking01.js: Removed. * LayoutTests/dom/xhtml/level3/core/documentsetstricterrorchecking01.xhtml: Removed. * LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt: Removed. * LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err.html: Removed. * LayoutTests/fast/dom/DOMImplementation/createDocumentType-err-expected.txt: Removed. * LayoutTests/fast/dom/DOMImplementation/createDocumentType-err.html: Removed. * LayoutTests/fast/dom/Document/createAttributeNS-namespace-err-expected.txt: Removed. * LayoutTests/fast/dom/Document/createAttributeNS-namespace-err.html: Removed. * LayoutTests/fast/dom/Document/createElement-invalid-names-expected.txt: Removed. * LayoutTests/fast/dom/Document/createElement-invalid-names.html: Removed. * LayoutTests/fast/dom/Document/createElementNS-namespace-err-expected.txt: Removed. * LayoutTests/fast/dom/Document/createElementNS-namespace-err.html: Removed. * LayoutTests/fast/dom/Element/setAttributeNS-namespace-err-expected.txt: Removed. * LayoutTests/fast/dom/Element/setAttributeNS-namespace-err.html: Removed. * LayoutTests/fast/dom/qualified-name-validation-expected.txt: Removed. * LayoutTests/fast/dom/qualified-name-validation.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createDocument.html: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createDocumentType-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createDocumentType.html: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createAttribute-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElement-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElement.html: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS.html: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createElementNS.js: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes.html: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/name-validation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/name-validation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/productions.js: * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dataset-set-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dataset-set.html: * LayoutTests/tests-options.json: Canonical link: https://commits.webkit.org/308542@main
087cc79 to
14676a6
Compare
Collaborator
|
Committed 308542@main (14676a6): https://commits.webkit.org/308542@main Reviewed commits have been landed. Closing PR #56248 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
14676a6
5511f82