Skip to content

Allow log streaming from webpushd #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-early-warning-system merged 0 commits into from
May 9, 2022
Merged

Allow log streaming from webpushd #567

webkit-early-warning-system merged 0 commits into from
May 9, 2022

Conversation

@bnham
Copy link
Contributor

@bnham bnham commented May 9, 2022 •
edited by webkit-early-warning-system
Loading

5d57e76

Allow log streaming from webpushd
https://bugs.webkit.org/show_bug.cgi?id=240238

Reviewed by Per Arne Vollan.

`log stream` outputs nothing from webpushd because we blocked the diagnosticd service in its
sandbox. We should allow that and also block awdd since it's unlikely that webpushd needs
access to the wireless diagnostics daemon.

* webpushd/mac/com.apple.WebKit.webpushd.sb.in:

Canonical link: https://commits.webkit.org/250425@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@bnham bnham self-assigned this May 9, 2022
@bnham bnham added WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). WebKit Nightly Build labels May 9, 2022
@bnham bnham requested a review from pvollan May 9, 2022 17:03
pvollan
pvollan approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@bnham bnham added the merge-queue Applied to send a pull request to merge-queue label May 9, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/webpushd-sandbox-logging branch from 64cf3bb to 5d57e76 Compare May 9, 2022 20:44
@webkit-early-warning-system webkit-early-warning-system merged commit 5d57e76 into WebKit:main May 9, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 9, 2022

Committed r293988 (250425@main): https://commits.webkit.org/250425@main

Reviewed commits have been landed. Closing PR #567 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvollan pvollan pvollan approved these changes

Assignees

@bnham bnham

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bnham @webkit-early-warning-system @pvollan