Skip to content

Stop re-declaring speechVoicesIncludingSuperCompactWithCompletionHandler in PlatformSpeechSynthesizerCocoa.mm #56765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Jan 18, 2026
Merged

Stop re-declaring speechVoicesIncludingSuperCompactWithCompletionHandler in PlatformSpeechSynthesizerCocoa.mm #56765

webkit-commit-queue merged 1 commit into from
Jan 18, 2026
+0 −6

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Jan 17, 2026 •
edited by webkit-early-warning-system
Loading

cc68924

Stop re-declaring speechVoicesIncludingSuperCompactWithCompletionHandler in PlatformSpeechSynthesizerCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=305698

Reviewed by Darin Adler.

Stop re-declaring speechVoicesIncludingSuperCompactWithCompletionHandler
in PlatformSpeechSynthesizerCocoa.mm as it is already present in
pal/spi/cocoa/AXSpeechManagerSPI.h.

* Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm:

Canonical link: https://commits.webkit.org/305770@main

d7d4885

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jan 17, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 17, 2026 •
edited
Loading

EWS run on current version of this PR (hash d7d4885)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 17, 2026
@cdumez cdumez mentioned this pull request Jan 17, 2026
Merged
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 17, 2026
@cdumez cdumez marked this pull request as ready for review January 18, 2026 01:06
@cdumez cdumez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 18, 2026
@cdumez
Stop re-declaring speechVoicesIncludingSuperCompactWithCompletionHand…
cc68924 
…ler in PlatformSpeechSynthesizerCocoa.mm

https://bugs.webkit.org/show_bug.cgi?id=305698

Reviewed by Darin Adler.

Stop re-declaring speechVoicesIncludingSuperCompactWithCompletionHandler
in PlatformSpeechSynthesizerCocoa.mm as it is already present in
pal/spi/cocoa/AXSpeechManagerSPI.h.

* Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm:

Canonical link: https://commits.webkit.org/305770@main
@webkit-commit-queue webkit-commit-queue force-pushed the 305698_speechVoicesIncludingSuperCompactWithCompletionHandler_redeclare branch from d7d4885 to cc68924 Compare January 18, 2026 01:26
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 18, 2026

Committed 305770@main (cc68924): https://commits.webkit.org/305770@main

Reviewed commits have been landed. Closing PR #56765 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cc68924 into WebKit:main Jan 18, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darinadler darinadler darinadler approved these changes

@minorninth minorninth Awaiting requested review from minorninth

@twilco twilco Awaiting requested review from twilco

Assignees

@cdumez cdumez

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot