Skip to content

Conversation

@philn
Copy link
Member

@philn philn commented Jan 17, 2026

@philn philn requested a review from cdumez as a code owner January 17, 2026 15:16
@philn philn self-assigned this Jan 17, 2026
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 17, 2026
@philn philn requested a review from calvaris January 17, 2026 15:16
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 17, 2026
@philn philn removed the merging-blocked Applied to prevent a change from being merged label Jan 17, 2026
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jan 19, 2026
https://bugs.webkit.org/show_bug.cgi?id=305699

Reviewed by Xabier Rodriguez-Calvar.

Store the RiceBackend as a ThreadSafeWeakPtr and access it from Rice callbacks and GSources as a
RefPtr.

* Source/WebKit/NetworkProcess/webrtc/rice/RiceBackend.cpp:
(WebKit::RiceBackend::gatherSocketAddresses):

Canonical link: https://commits.webkit.org/305812@main
@webkit-commit-queue
Copy link
Collaborator

Committed 305812@main (dfdc4d4): https://commits.webkit.org/305812@main

Reviewed commits have been landed. Closing PR #56766 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dfdc4d4 into WebKit:main Jan 19, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 19, 2026
@philn philn deleted the eng/305699 branch January 19, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants