Skip to content

Update style checker to prevent addition of new protected*() / checked*() member functions #57194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Jan 25, 2026
Merged

Update style checker to prevent addition of new protected*() / checked*() member functions #57194

webkit-commit-queue merged 1 commit into from
Jan 25, 2026
+111 −3

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Jan 25, 2026 •
edited by webkit-early-warning-system
Loading

20fc18a

Update style checker to prevent addition of new `protected*()` / `checked*()` member functions
https://bugs.webkit.org/show_bug.cgi?id=306200

Reviewed by Ryosuke Niwa.

Update style checker to prevent addition of new `protected*()` / `checked*()`
member functions, and recommend using `protect()` at call sites instead.

* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition):
(CppChecker):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_protected_getter):
(WebKitStyleTest):
(WebKitStyleTest.test_checked_getter):
(WebKitStyleTest.test_names):

Canonical link: https://commits.webkit.org/306163@main

123571d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv   🧪 mac-intel-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jan 25, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 25, 2026 •
edited
Loading

EWS run on previous version of this PR (hash ab53cc5)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
  🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 webkitpy   🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 wpe-cairo-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv ⏳ 🧪 mac-intel-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 25, 2026
@cdumez cdumez changed the title Update style checker to prevent addition of new protected*() / checked() member functions Update style checker to prevent addition of new protected*() / checked*() member functions Jan 25, 2026
@cdumez cdumez force-pushed the 306200_style_check_protected_getters branch from ab53cc5 to 714945e Compare January 25, 2026 05:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 25, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 714945e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ❌ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ❌ 🛠 vision-apple
❌ 🧪 webkitpy   🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
  🧪 vision-wk2   🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ⏳ 🧪 mac-intel-wk2
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez force-pushed the 306200_style_check_protected_getters branch from 714945e to 123571d Compare January 25, 2026 06:00
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 25, 2026 •
edited
Loading

EWS run on current version of this PR (hash 123571d)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv   🧪 mac-intel-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jan 25, 2026
@cdumez
Update style checker to prevent addition of new protected*() / `che…
20fc18a 
…cked*()` member functions

https://bugs.webkit.org/show_bug.cgi?id=306200

Reviewed by Ryosuke Niwa.

Update style checker to prevent addition of new `protected*()` / `checked*()`
member functions, and recommend using `protect()` at call sites instead.

* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition):
(CppChecker):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_protected_getter):
(WebKitStyleTest):
(WebKitStyleTest.test_checked_getter):
(WebKitStyleTest.test_names):

Canonical link: https://commits.webkit.org/306163@main
@webkit-commit-queue webkit-commit-queue force-pushed the 306200_style_check_protected_getters branch from 123571d to 20fc18a Compare January 25, 2026 07:23
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 25, 2026

Committed 306163@main (20fc18a): https://commits.webkit.org/306163@main

Reviewed commits have been landed. Closing PR #57194 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 20fc18a into WebKit:main Jan 25, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rniwa rniwa rniwa approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@gsnedders gsnedders Awaiting requested review from gsnedders gsnedders is a code owner

Assignees

@cdumez cdumez

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa