[LBSE] Cache visual overflow rect computation

[nikolaszimmermann]

4bc53a1

[LBSE] Cache visual overflow rect computation
https://bugs.webkit.org/show_bug.cgi?id=306213

Reviewed by Rob Buis.

SVGBoundingBoxComputation::computeVisualOverflowRect() is expensive and appears
frequently in profiling. This patch ensures the cached visual overflow rect is
properly invalidated when:

1. Style changes affect visual overflow (stroke properties, outline, clip-path,
   mask, filter, marker references)
2. Referenced SVG resource content changes (e.g., a <rect> inside <clipPath>
   changes its geometry)

Add RenderLayerModelObject::invalidateCachedVisualOverflowRect() virtual method
with overrides in RenderSVGModelObject, RenderSVGRoot, and RenderSVGText.

Override RenderSVGResourceContainer::layout() to call repaintAllClients() after
children layout, ensuring clients are notified when resource content changes.

In CSSSVGResourceElementClient::resourceChanged(), always invalidate the cached
visual overflow rect, but skip the repaint call during layout since the existing
post-layout mechanism handles it.

Covered by existing tests.

* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::CSSSVGResourceElementClient::resourceChanged):
* Source/WebCore/rendering/RenderLayerModelObject.h:
(WebCore::RenderLayerModelObject::invalidateCachedVisualOverflowRect):
* Source/WebCore/rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layoutChildren):
* Source/WebCore/rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::styleDidChange):
* Source/WebCore/rendering/svg/RenderSVGModelObject.h:
(WebCore::RenderSVGModelObject::visualOverflowRectEquivalent const):
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::layout):
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:
* Source/WebCore/rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layoutChildren):
* Source/WebCore/rendering/svg/RenderSVGRoot.h:
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::updatePositionAndOverflow):
* Source/WebCore/rendering/svg/RenderSVGText.h:

Canonical link: https://commits.webkit.org/306815@main

cdb7643

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	✅ 🛠 wpe-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash e29d537)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	⏳ 🛠 wpe-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash cdb7643)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	✅ 🛠 wpe-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim

[rwlbuis]

LGTM now!

[webkit-commit-queue]

Committed 306815@main (4bc53a1): https://commits.webkit.org/306815@main

Reviewed commits have been landed. Closing PR #57206 and removing active labels.