-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WPE] Drop WTF_ALLOW_UNSAFE_BUFFER_USAGE under Source/WebKit/UIProcess/wpe/ #57658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
aperezdc:bug306728-reduce-unsafe-buffer
Feb 2, 2026
Merged
[WPE] Drop WTF_ALLOW_UNSAFE_BUFFER_USAGE under Source/WebKit/UIProcess/wpe/ #57658
webkit-commit-queue
merged 1 commit into
WebKit:main
from
aperezdc:bug306728-reduce-unsafe-buffer
Feb 2, 2026
+16
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
EWS run on previous version of this PR (hash 830a545) Details |
carlosgcampos
approved these changes
Feb 2, 2026
830a545 to
513e682
Compare
Collaborator
|
EWS run on current version of this PR (hash 513e682) Details |
…s/wpe/ https://bugs.webkit.org/show_bug.cgi?id=306728 Reviewed by Carlos Garcia Campos. * Source/WebKit/UIProcess/wpe/AcceleratedBackingStore.cpp: Remove WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END} around Skia header includes, as WTF_IGNORE_WARNINGS_IN_THIRD_PARTY_CODE_{BEGIN,END} already prevents the warnings. * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::preferredBufferFormats const): Use a std::span to wrap the GArray retuned by wpe_buffer_formats_get_format_modifiers() and use that to directly instantiate RendererBufferFormat::Format objects, without needing an explicit loop. * Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp: (WebKit::clipboardFormats): Use a std::span to help convert a GStrv to a Vector<String> by taking advantage of the Vector constructor that takes a lambda as element generator. (WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite): Use a std::span to iterate over the GStrv of clipboard formats. Canonical link: https://commits.webkit.org/306624@main
513e682 to
ef7a0c8
Compare
Collaborator
|
Committed 306624@main (ef7a0c8): https://commits.webkit.org/306624@main Reviewed commits have been landed. Closing PR #57658 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ef7a0c8
513e682