Skip to content

Conversation

@aperezdc
Copy link
Contributor

@aperezdc aperezdc commented Feb 1, 2026

ef7a0c8

[WPE] Drop WTF_ALLOW_UNSAFE_BUFFER_USAGE under Source/WebKit/UIProcess/wpe/
https://bugs.webkit.org/show_bug.cgi?id=306728

Reviewed by Carlos Garcia Campos.

* Source/WebKit/UIProcess/wpe/AcceleratedBackingStore.cpp: Remove
WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END} around Skia header includes,
as WTF_IGNORE_WARNINGS_IN_THIRD_PARTY_CODE_{BEGIN,END} already prevents
the warnings.
* Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp:
(WebKit::WebPageProxy::preferredBufferFormats const): Use a std::span to
wrap the GArray retuned by wpe_buffer_formats_get_format_modifiers() and
use that to directly instantiate RendererBufferFormat::Format objects,
without needing an explicit loop.
* Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp:
(WebKit::clipboardFormats): Use a std::span to help convert a GStrv to
a Vector<String> by taking advantage of the Vector constructor that
takes a lambda as element generator.
(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite): Use a

std::span to iterate over the GStrv of clipboard formats.
Canonical link: https://commits.webkit.org/306624@main

513e682

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 💥 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 💥 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@aperezdc aperezdc requested a review from a team as a code owner February 1, 2026 18:39
@aperezdc aperezdc self-assigned this Feb 1, 2026
@aperezdc aperezdc added the WPE WebKit WebKit WPE component label Feb 1, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 1, 2026
@aperezdc aperezdc force-pushed the bug306728-reduce-unsafe-buffer branch from 830a545 to 513e682 Compare February 2, 2026 09:39
@aperezdc aperezdc added the merge-queue Applied to send a pull request to merge-queue label Feb 2, 2026
@aperezdc aperezdc added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Feb 2, 2026
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Feb 2, 2026
@aperezdc aperezdc added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 2, 2026
…s/wpe/

https://bugs.webkit.org/show_bug.cgi?id=306728

Reviewed by Carlos Garcia Campos.

* Source/WebKit/UIProcess/wpe/AcceleratedBackingStore.cpp: Remove
WTF_ALLOW_UNSAFE_BUFFER_USAGE_{BEGIN,END} around Skia header includes,
as WTF_IGNORE_WARNINGS_IN_THIRD_PARTY_CODE_{BEGIN,END} already prevents
the warnings.
* Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp:
(WebKit::WebPageProxy::preferredBufferFormats const): Use a std::span to
wrap the GArray retuned by wpe_buffer_formats_get_format_modifiers() and
use that to directly instantiate RendererBufferFormat::Format objects,
without needing an explicit loop.
* Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp:
(WebKit::clipboardFormats): Use a std::span to help convert a GStrv to
a Vector<String> by taking advantage of the Vector constructor that
takes a lambda as element generator.
(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite): Use a

std::span to iterate over the GStrv of clipboard formats.
Canonical link: https://commits.webkit.org/306624@main
@webkit-commit-queue webkit-commit-queue force-pushed the bug306728-reduce-unsafe-buffer branch from 513e682 to ef7a0c8 Compare February 2, 2026 12:10
@webkit-commit-queue
Copy link
Collaborator

Committed 306624@main (ef7a0c8): https://commits.webkit.org/306624@main

Reviewed commits have been landed. Closing PR #57658 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ef7a0c8 into WebKit:main Feb 2, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 2, 2026
@aperezdc aperezdc deleted the bug306728-reduce-unsafe-buffer branch February 2, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants