Skip to content

Conversation

@Constellation
Copy link
Member

@Constellation Constellation commented Feb 4, 2026

10d5c98

[JSC] Enable AsyncStackTrace
https://bugs.webkit.org/show_bug.cgi?id=306918
rdar://169587801

Reviewed by Sosuke Suzuki.

We carefully did A/B test and confirmed it is neutral. So let's enable
it. AsyncStackTrace will offer stack trace with asynchronous context
which keeps entries connected from the previous async execution.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/uncapturederror-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderVariables-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/shader/execution/flow_control/eval_order-expected.txt:
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/306759@main

ab535ac

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt 🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation requested a review from a team as a code owner February 4, 2026 03:56
@Constellation Constellation self-assigned this Feb 4, 2026
@Constellation Constellation added the ANGLE Bugs related to the ANGLE project label Feb 4, 2026
@Constellation Constellation added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. and removed ANGLE Bugs related to the ANGLE project labels Feb 4, 2026
Copy link
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation force-pushed the eng/JSC-Enable-AsyncStackTrace branch from 478ff98 to ab535ac Compare February 4, 2026 05:31
@Constellation Constellation added ANGLE Bugs related to the ANGLE project and removed JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. labels Feb 4, 2026
@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 4, 2026
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Enable-AsyncStackTrace branch from ab535ac to bdc256e Compare February 4, 2026 07:48
https://bugs.webkit.org/show_bug.cgi?id=306918
rdar://169587801

Reviewed by Sosuke Suzuki.

We carefully did A/B test and confirmed it is neutral. So let's enable
it. AsyncStackTrace will offer stack trace with asynchronous context
which keeps entries connected from the previous async execution.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/uncapturederror-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderVariables-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/shader/execution/flow_control/eval_order-expected.txt:
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/306759@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Enable-AsyncStackTrace branch from bdc256e to 10d5c98 Compare February 4, 2026 07:50
@webkit-commit-queue
Copy link
Collaborator

Committed 306759@main (10d5c98): https://commits.webkit.org/306759@main

Reviewed commits have been landed. Closing PR #57832 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 10d5c98 into WebKit:main Feb 4, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 4, 2026
@Constellation Constellation deleted the eng/JSC-Enable-AsyncStackTrace branch February 4, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ANGLE Bugs related to the ANGLE project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants