Skip to content

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Feb 4, 2026

f7f0f38

Address unsafe data member warning in ViewGestureControllerIOS.mm
https://bugs.webkit.org/show_bug.cgi?id=306924

Reviewed by Darin Adler and Anne van Kesteren.

* Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController startInteractiveTransition:]):
(-[WKSwipeTransitionController shouldBeginInteractiveTransition:]):

Canonical link: https://commits.webkit.org/306760@main

8075e19

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Feb 4, 2026
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Feb 4, 2026
@cdumez cdumez force-pushed the 306924_ViewGestureControllerIOS_safer_cpp branch from 603d457 to 8075e19 Compare February 4, 2026 04:45
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Feb 4, 2026
https://bugs.webkit.org/show_bug.cgi?id=306924

Reviewed by Darin Adler and Anne van Kesteren.

* Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController startInteractiveTransition:]):
(-[WKSwipeTransitionController shouldBeginInteractiveTransition:]):

Canonical link: https://commits.webkit.org/306760@main
@webkit-commit-queue webkit-commit-queue force-pushed the 306924_ViewGestureControllerIOS_safer_cpp branch from 8075e19 to f7f0f38 Compare February 4, 2026 08:34
@webkit-commit-queue
Copy link
Collaborator

Committed 306760@main (f7f0f38): https://commits.webkit.org/306760@main

Reviewed commits have been landed. Closing PR #57837 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f7f0f38 into WebKit:main Feb 4, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit2 Bugs relating to the WebKit2 API layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants